Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddl: fix bug that range columns partition table add partitions failed (#12348) #12815

Merged
merged 3 commits into from
Oct 18, 2019
Merged

ddl: fix bug that range columns partition table add partitions failed (#12348) #12815

merged 3 commits into from
Oct 18, 2019

Conversation

crazycs520
Copy link
Contributor

What problem does this PR solve?

cherry-pick #12348

What is changed and how it works?

Check List

Tests

  • Unit test

@crazycs520
Copy link
Contributor Author

/run-all-tests

@crazycs520 crazycs520 added the priority/release-blocker This issue blocks a release. Please solve it ASAP. label Oct 18, 2019
@tiancaiamao tiancaiamao mentioned this pull request Oct 18, 2019
Merged
@crazycs520
Copy link
Contributor Author

/run-all-tests

1 similar comment
@crazycs520
Copy link
Contributor Author

/run-all-tests

@crazycs520
Copy link
Contributor Author

/rebuild

1 similar comment
@crazycs520
Copy link
Contributor Author

/rebuild

@crazycs520
Copy link
Contributor Author

/run-all-tests

1 similar comment
@zyxbest
Copy link
Contributor

zyxbest commented Oct 18, 2019

/run-all-tests

bb7133
bb7133 reviewed Oct 18, 2019
View reviewed changes
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bb7133 bb7133 added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 18, 2019
@zyxbest
Copy link
Contributor

zyxbest commented Oct 18, 2019

/build

@bb7133
Copy link
Member

bb7133 commented Oct 18, 2019

/run-unit-test

@tiancaiamao
Copy link
Contributor

LGTM

@tiancaiamao tiancaiamao added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 18, 2019
zimulala
zimulala approved these changes Oct 18, 2019
View reviewed changes
Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zimulala zimulala merged commit 399c105 into pingcap:release-3.0 Oct 18, 2019
@crazycs520 crazycs520 deleted the 12348-3.0 branch October 18, 2019 07:45
@bb7133 bb7133 mentioned this pull request Nov 8, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bb7133 bb7133 bb7133 left review comments

@tiancaiamao tiancaiamao tiancaiamao approved these changes

@zimulala zimulala zimulala approved these changes

Assignees
No one assigned
Labels
priority/release-blocker This issue blocks a release. Please solve it ASAP. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@crazycs520 @zyxbest @bb7133 @tiancaiamao @zimulala