Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddl: check column and partition value have same type for range column partition (#12664) #12792

Merged
merged 6 commits into from
Oct 18, 2019
Merged

ddl: check column and partition value have same type for range column partition (#12664) #12792

merged 6 commits into from
Oct 18, 2019

Conversation

tiancaiamao
Copy link
Contributor

Cherry-pick #12664

@tiancaiamao tiancaiamao added type/3.0 cherry-pick type/bugfix This PR fixes a bug. priority/release-blocker This issue blocks a release. Please solve it ASAP. labels Oct 17, 2019
@tiancaiamao
Copy link
Contributor Author

We should bring this to v3.0.5
PTAL @jackysp @zimulala @crazycs520

@tiancaiamao
Copy link
Contributor Author

Block by #12718

@jackysp
Copy link
Member

jackysp commented Oct 18, 2019

CI failed. @tiancaiamao

@tiancaiamao
Copy link
Contributor Author

Block by #12815

@tiancaiamao
Copy link
Contributor Author

/run-all-tests

jackysp
jackysp reviewed Oct 18, 2019
View reviewed changes
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackysp jackysp added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 18, 2019
@tiancaiamao
Copy link
Contributor Author

/rebuild

@tiancaiamao
Copy link
Contributor Author

/run-all-tests

crazycs520
crazycs520 reviewed Oct 18, 2019
View reviewed changes
Copy link
Contributor

@crazycs520 crazycs520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tiancaiamao tiancaiamao added status/all tests passed status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 18, 2019
@zimulala zimulala merged commit 14097d8 into pingcap:release-3.0 Oct 18, 2019
@tiancaiamao tiancaiamao deleted the cherry-partition-3.0 branch October 18, 2019 09:03
@fatpa fatpa mentioned this pull request Nov 2, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crazycs520 crazycs520 crazycs520 left review comments

@jackysp jackysp jackysp left review comments

@zimulala zimulala zimulala approved these changes

Assignees
No one assigned
Labels
priority/release-blocker This issue blocks a release. Please solve it ASAP. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tiancaiamao @jackysp @zimulala @crazycs520