Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddl: fix create table check for range columns partition #12622 #12718

Merged
merged 3 commits into from
Oct 18, 2019
Merged

ddl: fix create table check for range columns partition #12622 #12718

merged 3 commits into from
Oct 18, 2019

Conversation

tiancaiamao
Copy link
Contributor

Cherry-pick #12622

PTAL @crazycs520 @jackysp @winkyao

jackysp
jackysp reviewed Oct 15, 2019
View reviewed changes
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackysp jackysp added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 15, 2019
@tiancaiamao tiancaiamao added the priority/release-blocker This issue blocks a release. Please solve it ASAP. label Oct 16, 2019
@tiancaiamao
Copy link
Contributor Author

PTAL @crazycs520 @winkyao

@tiancaiamao tiancaiamao mentioned this pull request Oct 17, 2019
Merged
crazycs520
crazycs520 approved these changes Oct 17, 2019
View reviewed changes
Copy link
Contributor

@crazycs520 crazycs520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crazycs520
Copy link
Contributor

/run-all-tests

@zz-jason zz-jason added status/LGT2 Indicates that a PR has LGTM 2. status/can-merge Indicates a PR has been approved by a committer. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 17, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Oct 17, 2019

Your auto merge job has been accepted, waiting for 12788, 12791, 12790, 12782

@sre-bot
Copy link
Contributor

sre-bot commented Oct 17, 2019

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Oct 17, 2019

@tiancaiamao merge failed.

@zyxbest
Copy link
Contributor

zyxbest commented Oct 17, 2019

/run-all-tests

@tiancaiamao
Copy link
Contributor Author

/run-all-tests

2 similar comments
@zyxbest
Copy link
Contributor

zyxbest commented Oct 18, 2019

/run-all-tests

@zyxbest
Copy link
Contributor

zyxbest commented Oct 18, 2019

/run-all-tests

@jackysp jackysp merged commit f45c29b into pingcap:release-3.0 Oct 18, 2019
@tiancaiamao tiancaiamao deleted the create-table-cherry-3.0 branch October 18, 2019 05:25
@you06 you06 added the sig/sql-infra SIG: SQL Infra label Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackysp jackysp jackysp left review comments

@crazycs520 crazycs520 crazycs520 approved these changes

Assignees
No one assigned
Labels
priority/release-blocker This issue blocks a release. Please solve it ASAP. sig/sql-infra SIG: SQL Infra status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@tiancaiamao @crazycs520 @sre-bot @zyxbest @jackysp @zz-jason @you06