Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddl: fix bug that range columns partition table add partitions failed #12348

Merged
merged 6 commits into from
Sep 26, 2019
Merged

ddl: fix bug that range columns partition table add partitions failed #12348

merged 6 commits into from
Sep 26, 2019

Conversation

crazycs520
Copy link
Contributor

What problem does this PR solve? 

create table t (a datetime) partition by range columns (a) (partition p1 values less than ('2019-06-01'), partition p2 values less than ('2019-07-01'));
alter table t add partition ( partition p3 values less than ('2019-08-01'));  -- should execute succeful.
(1659, u'Field \'"2019-06-01"\' is of a not allowed type for this type of partitioning')

What is changed and how it works?

  • Fix Add partition bug.

Check List

Tests

  • Integration test

Code changes

  • Has exported function/method change

Side effects

Related changes

  • Need to cherry-pick to the release branch

Release note

  • Fix the issue that range columns partition table add partitions failed.

@codecov
Copy link

codecov bot commented Sep 24, 2019 •
edited
Loading

Codecov Report

Merging #12348 into master will increase coverage by 0.2857%.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             master     #12348        +/-   ##
================================================
+ Coverage   79.7039%   79.9897%   +0.2857%     
================================================
  Files           461        461                
  Lines        101621     103347      +1726     
================================================
+ Hits          80996      82667      +1671     
- Misses        14800      14837        +37     
- Partials       5825       5843        +18

AilinKid
AilinKid reviewed Sep 24, 2019
View reviewed changes
Copy link
Contributor

@AilinKid AilinKid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

zimulala
zimulala reviewed Sep 24, 2019
View reviewed changes
ddl/ddl_api.go Outdated Show resolved Hide resolved
@crazycs520
Copy link
Contributor Author

/run-all-tests

bb7133
bb7133 reviewed Sep 26, 2019
View reviewed changes
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tiancaiamao
tiancaiamao reviewed Sep 26, 2019
View reviewed changes
ddl/ddl_api.go Show resolved Hide resolved
ddl/ddl_api.go Show resolved Hide resolved
@tiancaiamao
Copy link
Contributor

LGTM

@tiancaiamao tiancaiamao added the status/LGT2 Indicates that a PR has LGTM 2. label Sep 26, 2019
@tiancaiamao
Copy link
Contributor

/can-merge

@crazycs520 crazycs520 added the status/can-merge Indicates a PR has been approved by a committer. label Sep 26, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Sep 26, 2019

/run-all-tests

@sre-bot sre-bot merged commit e37464b into pingcap:master Sep 26, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Sep 26, 2019

cherry pick to release-3.0 failed

@sre-bot
Copy link
Contributor

sre-bot commented Sep 26, 2019

cherry pick to release-3.1 failed

@tiancaiamao
Copy link
Contributor

@crazycs520 This one is not cherry-pick to release-3.0 !

crazycs520 added a commit to crazycs520/tidb that referenced this pull request Oct 18, 2019
@crazycs520
ddl: fix bug that range columns partition table add partitions failed (…
0dd5b00 
…pingcap#12348)
@crazycs520 crazycs520 mentioned this pull request Oct 18, 2019
Merged
zimulala pushed a commit that referenced this pull request Oct 18, 2019
@crazycs520 @zimulala
ddl: fix bug that range columns partition table add partitions failed (…
399c105 
…#12348) (#12815)
@cyliu0
Copy link
Contributor

cyliu0 commented Nov 6, 2019

@crazycs520 This PR has been labeled needs-cherry-pick-3.1. Plz cherry pick this one to release-3.1

bb7133 pushed a commit to bb7133/tidb that referenced this pull request Nov 8, 2019
@crazycs520 @bb7133
ddl: fix bug that range columns partition table add partitions failed (…
be83b7f 
…pingcap#12348)
@bb7133 bb7133 mentioned this pull request Nov 8, 2019
Merged
bb7133 added a commit that referenced this pull request Nov 8, 2019
@bb7133
ddl: fix bug that range columns partition table add partitions failed (…
33b75a8 
…#12348) (#13295)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bb7133 bb7133 bb7133 left review comments

@zimulala zimulala zimulala left review comments

@AilinKid AilinKid AilinKid left review comments

@tiancaiamao tiancaiamao tiancaiamao approved these changes

Assignees
No one assigned
Labels
status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@crazycs520 @tiancaiamao @sre-bot @cyliu0 @bb7133 @zimulala @AilinKid