Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Call For Participation: vectorize all Decimal builtin functions #12102

Closed
30 tasks done
qw4990 opened this issue Sep 10, 2019 · 5 comments
Closed
30 tasks done

Call For Participation: vectorize all Decimal builtin functions #12102

qw4990 opened this issue Sep 10, 2019 · 5 comments
Labels
component/expression good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. type/enhancement The issue or PR belongs to an enhancement.

Comments

@qw4990
Copy link
Contributor

qw4990 commented Sep 10, 2019 •
edited
Loading

This issue is used to trace all vectorized Decimal builtin functions, which is a part of #12058.

NOTE:

  1. Feel free to join us in the wg-vec-expr working group
  2. Please comment on this issue if you are working on any of the functions.

Note For Performance Challenge Teams: each PR on this issue has 50 score.
@qw4990 qw4990 added type/enhancement The issue or PR belongs to an enhancement. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. component/expression labels Sep 10, 2019
@qw4990 qw4990 changed the title Call For Participation: vectorize all decimal builtin functions Call For Participation: vectorize all Decimal builtin functions Sep 10, 2019
@qw4990 qw4990 mentioned this issue Sep 10, 2019
Closed
@FateTHarlaown
Copy link
Contributor

can I work at builtinAbsDecSig ? ^_^

@FateTHarlaown FateTHarlaown mentioned this issue Sep 11, 2019
Merged
@Reminiscent Reminiscent mentioned this issue Sep 11, 2019
Merged
This was referenced Sep 17, 2019
Merged
Merged
This was referenced Oct 9, 2019
Merged
Merged
Merged
Merged
This was referenced Oct 16, 2019
Merged
Merged
@hey-kong hey-kong mentioned this issue Oct 29, 2019
Merged
@soobun soobun mentioned this issue Nov 6, 2019
Merged
@CSFresh CSFresh mentioned this issue Nov 6, 2019
Merged
@catror catror mentioned this issue Nov 7, 2019
Merged
This was referenced Nov 9, 2019
Merged
Merged
catror added a commit to catror/tidb that referenced this issue Nov 14, 2019
@catror
expression: implement vectorized evaluation for `builtinCastDecimalA…
d600fb7 
…sDecimalSig` (pingcap#12102)
@catror catror mentioned this issue Nov 14, 2019
Closed
@catror catror mentioned this issue Nov 14, 2019
Merged
@Thincher
Copy link
Contributor

let me fix:
builtinUnixTimestampDecSig

catror added a commit to catror/tidb that referenced this issue Nov 15, 2019
@catror
expression: implement vectorized evaluation for `builtinCastDecimalAs…
7f5a451 
…DecimalSig` (pingcap#12102)
@Zhuchengyu04 Zhuchengyu04 mentioned this issue Nov 16, 2019
Merged
@ChiaoTeo
Copy link
Contributor

I will fix :
builtinCastRealAsDecimalSig
builtinCastDurationAsDecimalSig
builtinCastStringAsDecimalSig
builtinCastJSONAsDecimalSig

@pingyu
Copy link
Contributor

pingyu commented Nov 17, 2019

Let me fix:
builtinUnaryMinusDecimalSig

@pingyu pingyu mentioned this issue Nov 17, 2019
Merged
@Thincher Thincher mentioned this issue Nov 19, 2019
Merged
This was referenced Nov 19, 2019
Closed
Merged
@catror catror mentioned this issue Nov 19, 2019
Closed
@tangwz tangwz mentioned this issue Dec 3, 2019
Merged
catror added a commit to catror/tidb that referenced this issue Dec 9, 2019
@catror
expression: implement vectorized evaluation for `builtinCastIntAsDec…
12f0667 
…imalSig` (pingcap#12102)
@qw4990
Copy link
Contributor Author

qw4990 commented Mar 6, 2020

Close due to finish.

@qw4990 qw4990 closed this as completed Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component/expression good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@pingyu @zz-jason @qw4990 @FateTHarlaown @Thincher @ChiaoTeo