Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: implement vectorized evaluation for ‘builtinFloorDecToDecSig’ #13409

Merged
merged 23 commits into from
Nov 16, 2019
Merged

expression: implement vectorized evaluation for ‘builtinFloorDecToDecSig’ #13409

merged 23 commits into from
Nov 16, 2019

Conversation

Zhuchengyu04
Copy link
Contributor

@Zhuchengyu04 Zhuchengyu04 commented Nov 13, 2019 •
edited by qw4990
Loading

PCP #12102

What problem does this PR solve?

implement vectorized evaluation for builtinFloorDecToDecSig

What is changed and how it works?

goos: windows
goarch: amd64
pkg: github.com/pingcap/tidb/expression
BenchmarkVectorizedBuiltinMathFunc/builtinFloorDecToDecSig-VecBuiltinFunc-8                 6014            255691 ns/op           38544 B/op        803 allocs/op
BenchmarkVectorizedBuiltinMathFunc/builtinFloorDecToDecSig-NonVecBuiltinFunc-8              4005            267289 ns/op           57072 B/op       1189 allocs/op
PASS
ok      github.com/pingcap/tidb/expression      2.940s

Check List

Tests

  • Unit tests

@Zhuchengyu04 Zhuchengyu04 requested a review from a team as a code owner November 13, 2019 01:58
@sre-bot sre-bot added the contribution This PR is from a community contributor. label Nov 13, 2019
@ghost ghost requested review from wshwsh12 and XuHuaiyu and removed request for a team November 13, 2019 01:58
@CLAassistant
Copy link

CLAassistant commented Nov 13, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

XuHuaiyu
XuHuaiyu reviewed Nov 13, 2019
View reviewed changes
Copy link
Contributor

@XuHuaiyu XuHuaiyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the CI

@francis0407 francis0407 self-requested a review November 13, 2019 07:04
francis0407
francis0407 reviewed Nov 13, 2019
View reviewed changes
Copy link
Member

@francis0407 francis0407 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#13314 has been dealing with builtinCeilDecToDecSig, could you please fix the builtinFloorDecToDecSig in this PR?

@Zhuchengyu04
Copy link
Contributor Author

#13314 has been dealing with builtinCeilDecToDecSig, could you please fix the builtinFloorDecToDecSig in this PR?

With pleasure

@Zhuchengyu04 Zhuchengyu04 changed the title expression: implement vectorized evaluation for builtinCeilDecToDecSi… expression: implement vectorized evaluation for ‘builtinFloorDecToDecSig’ Nov 14, 2019
francis0407
francis0407 previously requested changes Nov 15, 2019
View reviewed changes
expression/builtin_math_vec.go Outdated Show resolved Hide resolved
expression/builtin_math_vec.go Outdated Show resolved Hide resolved
expression/builtin_math_vec.go Outdated Show resolved Hide resolved
expression/builtin_math_vec_test.go Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Nov 15, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@3ba0b4c). Click here to learn what that means.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #13409   +/-   ##
===========================================
  Coverage          ?   80.4631%           
===========================================
  Files             ?        472           
  Lines             ?     115177           
  Branches          ?          0           
===========================================
  Hits              ?      92675           
  Misses            ?      15277           
  Partials          ?       7225

francis0407
francis0407 reviewed Nov 15, 2019
View reviewed changes
Copy link
Member

@francis0407 francis0407 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@francis0407 francis0407 added status/LGT1 Indicates that a PR has LGTM 1. and removed status/ReqChange labels Nov 15, 2019
qw4990
qw4990 approved these changes Nov 16, 2019
View reviewed changes
Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

qw4990
qw4990 approved these changes Nov 16, 2019
View reviewed changes
Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qw4990 qw4990 added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 16, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Nov 16, 2019

Your auto merge job has been accepted, waiting for 13332

@sre-bot
Copy link
Contributor

sre-bot commented Nov 16, 2019

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Nov 16, 2019

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Nov 16, 2019

@Zhuchengyu04 merge failed.

@qw4990 qw4990 merged commit d8022f7 into pingcap:master Nov 16, 2019
@francis0407 francis0407 mentioned this pull request Nov 18, 2019
Merged
XiaTianliang pushed a commit to XiaTianliang/tidb that referenced this pull request Dec 21, 2019
@Zhuchengyu04 @XiaTianliang
expression: implement vectorized evaluation for ‘builtinFloorDecToDec…
76336c9 
…Sig’ (pingcap#13409)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XuHuaiyu XuHuaiyu XuHuaiyu left review comments

@francis0407 francis0407 francis0407 left review comments

@qw4990 qw4990 qw4990 approved these changes

Assignees
No one assigned
Labels
component/expression contribution This PR is from a community contributor. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Zhuchengyu04 @CLAassistant @sre-bot @qw4990 @XuHuaiyu @francis0407 @zz-jason