Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: implement vectorized evaluation for builtinArithmeticMinusDecimalSig #12584

Merged
merged 3 commits into from
Oct 14, 2019
Merged

expression: implement vectorized evaluation for builtinArithmeticMinusDecimalSig #12584

merged 3 commits into from
Oct 14, 2019

Conversation

hey-kong
Copy link
Contributor

@hey-kong hey-kong commented Oct 9, 2019

What problem does this PR solve?

Implement vectorized evaluation for builtinArithmeticMinusDecimalSig.#12102

What is changed and how it works?

BenchmarkVectorizedBuiltinArithmeticFunc/builtinArithmeticMinusDecimalSig-VecBuiltinFunc-4                 40449             28477 ns/op            0 B/op           0 allocs/op
BenchmarkVectorizedBuiltinArithmeticFunc/builtinArithmeticMinusDecimalSig-NonVecBuiltinFunc-4              14368             85609 ns/op        29424 B/op         613 allocs/op

Check List

Tests

  • Unit test

@sre-bot sre-bot added the contribution This PR is from a community contributor. label Oct 9, 2019
@hey-kong
Copy link
Contributor Author

hey-kong commented Oct 9, 2019

/run-unit-test

@AilinKid
Copy link
Contributor

/run-all-tests

@codecov
Copy link

codecov bot commented Oct 12, 2019 •
edited
Loading

Codecov Report

Merging #12584 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master    #12584   +/-   ##
=========================================
  Coverage   79.977%   79.977%           
=========================================
  Files          461       461           
  Lines       104485    104485           
=========================================
  Hits         83564     83564           
  Misses       14799     14799           
  Partials      6122      6122

@hey-kong
Copy link
Contributor Author

/run-unit-test

@SunRunAway SunRunAway removed their request for review October 12, 2019 12:59
qw4990
qw4990 reviewed Oct 14, 2019
View reviewed changes
Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qw4990 qw4990 added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 14, 2019
@qw4990 qw4990 requested a review from XuHuaiyu October 14, 2019 07:08
XuHuaiyu
XuHuaiyu approved these changes Oct 14, 2019
View reviewed changes
Copy link
Contributor

@XuHuaiyu XuHuaiyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@XuHuaiyu XuHuaiyu added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 14, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Oct 14, 2019

Your auto merge job has been accepted, waiting for 12640, 12220

@sre-bot
Copy link
Contributor

sre-bot commented Oct 14, 2019

/run-all-tests

@sre-bot sre-bot merged commit 876e794 into pingcap:master Oct 14, 2019
XiaTianliang pushed a commit to XiaTianliang/tidb that referenced this pull request Dec 21, 2019
@hey-kong @XiaTianliang
expression: implement vectorized evaluation for `builtinArithmeticMin…
558483f 
…usDecimalSig` (pingcap#12584)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qw4990 qw4990 qw4990 left review comments

@XuHuaiyu XuHuaiyu XuHuaiyu approved these changes

@Reminiscent Reminiscent Awaiting requested review from Reminiscent

Assignees
No one assigned
Labels
component/expression contribution This PR is from a community contributor. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hey-kong @AilinKid @sre-bot @qw4990 @XuHuaiyu