Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove some not very useful update events #1486

Merged
merged 4 commits into from
Jan 8, 2020
Merged

remove some not very useful update events #1486

merged 4 commits into from
Jan 8, 2020

Conversation

weekface
Copy link
Contributor

@weekface weekface commented Jan 6, 2020 •
edited by aylei
Loading

What problem does this PR solve?

fixes: #1471
Now, there are too many SuccessfulUpdate events emitted by tidb-operator, but they are not very useful.

	// by default, allow a source to send 25 events about an object
	// but control the refill rate to 1 new event every 5 minutes
	// this helps control the long-tail of events for things that are always
	// unhealthy
	defaultSpamBurst = 25
	defaultSpamQPS   = 1. / 300.
)

record.Event method in client-go has a spamFilter which is responsible for throttling
the amount of events a source and object can produce.

So we'd better remove these not very useful SuccessfulUpdate events.

What is changed and how does it work?

Check List

Tests

  • Unit test

Code changes

  • Has Go code change

Side effects

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Does this PR introduce a user-facing change?:

Remove some not very useful update events

aylei
aylei previously approved these changes Jan 6, 2020
View reviewed changes
Copy link
Contributor

@aylei aylei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cofyc
cofyc previously approved these changes Jan 6, 2020
View reviewed changes
Copy link
Contributor

@cofyc cofyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@weekface weekface dismissed stale reviews from cofyc and aylei via 169f666 January 6, 2020 05:11
cofyc
cofyc approved these changes Jan 6, 2020
View reviewed changes
Copy link
Contributor

@cofyc cofyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

onlymellb
onlymellb approved these changes Jan 6, 2020
View reviewed changes
Copy link
Contributor

@onlymellb onlymellb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@onlymellb
Copy link
Contributor

/merge

@sre-bot
Copy link
Contributor

sre-bot commented Jan 6, 2020

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Jan 6, 2020

@weekface merge failed.

@weekface
Copy link
Contributor Author

weekface commented Jan 7, 2020

/run-all-tests

@aylei
Copy link
Contributor

aylei commented Jan 8, 2020

/merge

@sre-bot
Copy link
Contributor

sre-bot commented Jan 8, 2020

/run-all-tests

@sre-bot sre-bot merged commit a561a5b into pingcap:master Jan 8, 2020
@sre-bot sre-bot mentioned this pull request Jan 8, 2020
Merged
@sre-bot
Copy link
Contributor

sre-bot commented Jan 8, 2020

cherry pick to release-1.1 in PR #1506

sre-bot added a commit that referenced this pull request Jan 8, 2020
@sre-bot
remove some not very useful update events (#1486) (#1506)
b514cb3
@weekface weekface deleted the remove-useless-update-events branch January 9, 2020 05:57
cofyc pushed a commit that referenced this pull request Jan 19, 2020
@weekface @sre-bot @cofyc
cherry-pick #1486 to release-1.0: remove some events (#1520)
27e02bd 
* remove some not very useful events

* fix CI

Co-authored-by: pingcap-github-bot <sre-bot@pingcap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cofyc cofyc cofyc approved these changes

@onlymellb onlymellb onlymellb approved these changes

@aylei aylei aylei left review comments

@tennix tennix Awaiting requested review from tennix

Assignees
No one assigned
Labels
needs-cherry-pick-1.1 status/can-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove some not very useful Events
5 participants
@weekface @onlymellb @sre-bot @aylei @cofyc