Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove some not very useful update events (#1486) #1506

Merged
merged 2 commits into from
Jan 8, 2020

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Jan 8, 2020

cherry-pick #1486 to release-1.1


What problem does this PR solve?

fixes: #1471
Now, there are too many SuccessfulUpdate events emitted by tidb-operator, but they are not very useful.

	// by default, allow a source to send 25 events about an object
	// but control the refill rate to 1 new event every 5 minutes
	// this helps control the long-tail of events for things that are always
	// unhealthy
	defaultSpamBurst = 25
	defaultSpamQPS   = 1. / 300.
)

record.Event method in client-go has a spamFilter which is responsible for throttling
the amount of events a source and object can produce.

So we'd better remove these not very useful SuccessfulUpdate events.

What is changed and how does it work?

Check List

Tests

  • Unit test

Code changes

  • Has Go code change

Side effects

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Does this PR introduce a user-facing change?:

Remove some not very useful update events

Copy link
Contributor

@onlymellb onlymellb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cofyc
Copy link
Contributor

cofyc commented Jan 8, 2020

/merge

@sre-bot
Copy link
Contributor Author

sre-bot commented Jan 8, 2020

Your auto merge job has been accepted, waiting for 1405, 1501, 1493, 1491

@sre-bot
Copy link
Contributor Author

sre-bot commented Jan 8, 2020

/run-all-tests

@sre-bot sre-bot merged commit b514cb3 into pingcap:release-1.1 Jan 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants