Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cherry-pick #1486 to release-1.0: remove some events #1520

Merged
merged 4 commits into from
Jan 19, 2020

Conversation

weekface
Copy link
Contributor

@weekface weekface commented Jan 9, 2020

What problem does this PR solve?

What is changed and how does it work?

Check List

Tests

  • Unit test

Code changes

  • Has Go code change

Side effects

Related changes

Does this PR introduce a user-facing change?:

NONE

aylei
aylei previously approved these changes Jan 15, 2020
Copy link
Contributor

@aylei aylei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aylei
Copy link
Contributor

aylei commented Jan 15, 2020

/merge

@sre-bot
Copy link
Contributor

sre-bot commented Jan 15, 2020

Your auto merge job has been accepted, waiting for 1519

@sre-bot
Copy link
Contributor

sre-bot commented Jan 15, 2020

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Jan 15, 2020

@weekface merge failed.

@cofyc
Copy link
Contributor

cofyc commented Jan 17, 2020

@weekface some static check failures must be resolved manually

@cofyc cofyc merged commit 27e02bd into pingcap:release-1.0 Jan 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants