Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tweak: explicitly set session max_execution_time to 600s #1608

Merged
merged 1 commit into from
Nov 2, 2023
Merged

tweak: explicitly set session max_execution_time to 600s #1608

merged 1 commit into from
Nov 2, 2023

Conversation

mornyx
Copy link
Collaborator

@mornyx mornyx commented Oct 31, 2023

close: #1604

This PR explicitly sets the session-level max_execution_time to avoid being affected by the global-level max_execution_time.

@mornyx
tweak: explicitly set session max_execution_time to 60s
c18be7f 
Signed-off-by: mornyx <mornyx.z@gmail.com>
@ti-chi-bot ti-chi-bot bot requested a review from Renkai October 31, 2023 02:23
@netlify
Copy link

netlify bot commented Oct 31, 2023 •
edited
Loading

✅ Deploy Preview for tidb-dashboard canceled.

Name Link
🔨 Latest commit c18be7f
🔍 Latest deploy log https://app.netlify.com/sites/tidb-dashboard/deploys/6540651d7f97c90008629d27

@ti-chi-bot ti-chi-bot bot added the size/XS label Oct 31, 2023
@codecov
Copy link

codecov bot commented Oct 31, 2023 •
edited
Loading

Codecov Report

Merging #1608 (c18be7f) into master (9e2ba5e) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1608      +/-   ##
==========================================
- Coverage   24.61%   24.60%   -0.01%     
==========================================
  Files         169      169              
  Lines       15290    15294       +4     
==========================================
  Hits         3763     3763              
- Misses      11245    11248       +3     
- Partials      282      283       +1
Flag Coverage Δ
backend_integration 9.27% <0.00%> (-0.01%) ⬇️
backend_ut 26.41% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e2ba5e...c18be7f. Read the comment docs.

@mornyx mornyx mentioned this pull request Oct 31, 2023
Closed
jackysp
jackysp approved these changes Nov 1, 2023
View reviewed changes
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 1, 2023

@jackysp: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mornyx mornyx changed the title tweak: explicitly set session max_execution_time to 60s tweak: explicitly set session max_execution_time to 600s Nov 2, 2023
@ti-chi-bot ti-chi-bot bot added the lgtm label Nov 2, 2023
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 2, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: baurine, jackysp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 2, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-11-02 02:46:00.232999747 +0000 UTC m=+3093957.820109892: ☑️ agreed by baurine.

@ti-chi-bot ti-chi-bot bot added the approved label Nov 2, 2023
@ti-chi-bot ti-chi-bot bot merged commit dd71084 into master Nov 2, 2023
13 of 16 checks passed
@ti-chi-bot ti-chi-bot bot deleted the mornyx/max-execution-time branch November 2, 2023 02:47
baurine pushed a commit that referenced this pull request Nov 8, 2023
@mornyx @baurine
tweak: explicitly set session max_execution_time to 600s (#1608)
a258d8a
baurine added a commit that referenced this pull request Nov 8, 2023
@baurine @mornyx
@horus @Connor1996 @nexustar
Release v2023.11.08.1 [skip pd_pr] (#1611)
7cb8b7f 
* Revert "Release v2023.11.02.1 (#1609)"

This reverts commit 865955c.

* feat(statements): show `plan_cache_hits` field (#1598)

* tweak: make the goroutine profile more verbose (#1450)

* feat: support additional OIDC parameters (#1567)

Co-authored-by: Sparkle <1284531+baurine@users.noreply.github.com>

* chore(sso): improve client secret security (#1599)

* chore(topsql): adjust TopSQL for clinic (#1601)

* chore(sso): support customize OIDC scopes (#1602)

* chore(clinic): support redirect back after login for clinic (#1603)

* chore(topsql): remove username for clinic (#1605)

* chore(topsql): show cluster name and disable auto-refresh for clinic (#1606)

* profiling: Add the support for TiKV heap profiling (#1600)

* increase the upper limit of testing time (#1526)

* fix cannot login when use ipv6 address (#1516)

* tweak: explicitly set session max_execution_time to 600s (#1608)

* profiling: reuse convertDotToSVG to generate tikv heap profile svg (#1610)

* update release version to 2023.11.08.1

---------

Co-authored-by: Yexiang Zhang <mornyx.z@gmail.com>
Co-authored-by: horus <horus.li@gmail.com>
Co-authored-by: Connor <zbk602423539@gmail.com>
Co-authored-by: nexustar <inexustar@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baurine baurine baurine approved these changes

@jackysp jackysp jackysp approved these changes

@Renkai Renkai Awaiting requested review from Renkai

Assignees
No one assigned
Labels
approved lgtm size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The connection of dashboard to TiDB should not be affected by some global variables
3 participants
@mornyx @baurine @jackysp