Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The connection of dashboard to TiDB should not be affected by some global variables #1604

Closed
jackysp opened this issue Oct 19, 2023 · 3 comments · Fixed by #1608
Closed

The connection of dashboard to TiDB should not be affected by some global variables #1604

jackysp opened this issue Oct 19, 2023 · 3 comments · Fixed by #1608
Labels

Comments

@jackysp
Copy link
Member

jackysp commented Oct 19, 2023

Bug Report

Please answer these questions before submitting your issue. Thanks!

What did you do?
Some clusters will set global variables like max_execution_time to make the database could fail fast queries.

What did you expect to see?
Some of these variables should not affect dashboard.

What did you see instead?
The slow query page failed to execute, because it exceeded the max_execution_time.
image

What version of TiDB Dashboard are you using (./tidb-dashboard --version)?
v7.1.1

@jackysp
Copy link
Member Author

jackysp commented Oct 19, 2023

PTAL @baurine @mornyx

@jackysp
Copy link
Member Author

jackysp commented Oct 19, 2023

It's better to set max_execution_time to 0 when creating the new database session in tidb-dashboard.

@mornyx
Copy link
Collaborator

mornyx commented Oct 31, 2023

Submitted a PR: #1608.

Setting max_execution_time to 0 can be risky (especially if it has been set to a lower value by the customer). So I set it to 600s. Please also help review this value, thanks. cc @baurine

@ti-chi-bot ti-chi-bot bot closed this as completed in #1608 Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants