Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(topsql): remove username for clinic #1605

Merged
merged 1 commit into from
Oct 20, 2023
Merged

chore(topsql): remove username for clinic #1605

merged 1 commit into from
Oct 20, 2023

Conversation

baurine
Copy link
Collaborator

@baurine baurine commented Oct 20, 2023

No description provided.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 20, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from baurine. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot requested a review from Renkai October 20, 2023 10:05
@netlify
Copy link

netlify bot commented Oct 20, 2023 •
edited
Loading

✅ Deploy Preview for tidb-dashboard ready!

Name Link
🔨 Latest commit 4c8520f
🔍 Latest deploy log https://app.netlify.com/sites/tidb-dashboard/deploys/653250e31acb050008506540
😎 Deploy Preview https://deploy-preview-1605--tidb-dashboard.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@baurine baurine marked this pull request as draft October 20, 2023 10:05
@baurine baurine self-assigned this Oct 20, 2023
@codecov
Copy link

codecov bot commented Oct 20, 2023 •
edited
Loading

Codecov Report

Merging #1605 (4c8520f) into master (e0b5631) will increase coverage by 1.71%.
The diff coverage is n/a.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1605      +/-   ##
==========================================
+ Coverage   24.71%   26.42%   +1.71%     
==========================================
  Files         169       97      -72     
  Lines       15227    10452    -4775     
==========================================
- Hits         3763     2762    -1001     
+ Misses      11182     7505    -3677     
+ Partials      282      185      -97
Flag Coverage Δ
backend_integration ?
backend_ut 26.42% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0b5631...4c8520f. Read the comment docs.

@baurine baurine removed their assignment Oct 20, 2023
@baurine baurine marked this pull request as ready for review October 20, 2023 10:06
@baurine baurine merged commit c6ca8cf into master Oct 20, 2023
15 of 16 checks passed
@baurine baurine deleted the chore/refine-topsql-for-clinic branch October 20, 2023 10:07
baurine added a commit that referenced this pull request Nov 8, 2023
@baurine
chore(topsql): remove username for clinic (#1605)
5e39765
baurine added a commit that referenced this pull request Nov 8, 2023
@baurine @mornyx
@horus @Connor1996 @nexustar
Release v2023.11.08.1 [skip pd_pr] (#1611)
7cb8b7f 
* Revert "Release v2023.11.02.1 (#1609)"

This reverts commit 865955c.

* feat(statements): show `plan_cache_hits` field (#1598)

* tweak: make the goroutine profile more verbose (#1450)

* feat: support additional OIDC parameters (#1567)

Co-authored-by: Sparkle <1284531+baurine@users.noreply.github.com>

* chore(sso): improve client secret security (#1599)

* chore(topsql): adjust TopSQL for clinic (#1601)

* chore(sso): support customize OIDC scopes (#1602)

* chore(clinic): support redirect back after login for clinic (#1603)

* chore(topsql): remove username for clinic (#1605)

* chore(topsql): show cluster name and disable auto-refresh for clinic (#1606)

* profiling: Add the support for TiKV heap profiling (#1600)

* increase the upper limit of testing time (#1526)

* fix cannot login when use ipv6 address (#1516)

* tweak: explicitly set session max_execution_time to 600s (#1608)

* profiling: reuse convertDotToSVG to generate tikv heap profile svg (#1610)

* update release version to 2023.11.08.1

---------

Co-authored-by: Yexiang Zhang <mornyx.z@gmail.com>
Co-authored-by: horus <horus.li@gmail.com>
Co-authored-by: Connor <zbk602423539@gmail.com>
Co-authored-by: nexustar <inexustar@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Renkai Renkai Awaiting requested review from Renkai

Assignees
No one assigned
Labels
area/frontend size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@baurine