syncer: sync region leaders between PD leader and follower #2591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: JmPotato <ghzpotato@gmail.com>
|
|
Signed-off-by: JmPotato <ghzpotato@gmail.com>
|
@sre-bot /run-all-tests |
Signed-off-by: JmPotato <ghzpotato@gmail.com>
JmPotato
force-pushed
the
sync_region_leader
branch
from
ed9710e to
265e2af
Compare
|
@sre-bot /run-all-tests |
disksing
reviewed
Jun 30, 2020
rleungx
reviewed
Jun 30, 2020
|
Would you like to add a test for it? |
Yes. I'm working on it. |
Signed-off-by: JmPotato <ghzpotato@gmail.com>
nolouch
reviewed
Jun 30, 2020
Co-authored-by: ShuNing <nolouch@gmail.com>
|
LGTM |
|
@disksing,Thanks for you review. |
nolouch
reviewed
Jun 30, 2020
Signed-off-by: JmPotato <ghzpotato@gmail.com>
|
I removed the |
|
@JmPotato That PR already merged. |
|
@sre-bot /rebuild |
Signed-off-by: JmPotato <ghzpotato@gmail.com>
Signed-off-by: JmPotato <ghzpotato@gmail.com>
|
/run-all-tests |
nolouch
approved these changes
Jul 1, 2020
disksing
approved these changes
Jul 1, 2020
|
/merge |
ti-srebot
added
the
status/can-merge
|
/run-all-tests |
|
Does this pr need to be cherry-picked to release-4.0? |
nolouch
added
the
needs-cherry-pick-release-4.0
|
@JmPotato we need. |
|
/run-cherry-picker |
|
cherry pick to release-4.0 failed |
1 similar comment
|
cherry pick to release-4.0 failed |
|
/run-cherry-picker |
|
cherry pick to release-4.0 failed |
|
/run-cherry-picker |
ti-srebot
pushed a commit
to ti-srebot/pd
that referenced
this pull request
Aug 13, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
cherry pick to release-4.0 in PR #2763 |
JmPotato
added a commit
that referenced
this pull request
Aug 19, 2020
Signed-off-by: JmPotato <ghzpotato@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: JmPotato ghzpotato@gmail.com
What problem does this PR solve?
Add the feature requested in issue #2542
What is changed and how it works?
Add
region_leadersfield inSyncRegionResponseto pass the region's leader info between PD leader and follower. And the region leader changing will also trigger sync now to make the region leader info more accurate.Check List
Tests
Related changes
pingcap/kvproto