Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

syncer: sync region leaders between PD leader and follower (#2591) #2763

Closed

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Aug 13, 2020

cherry-pick #2591 to release-4.0


Signed-off-by: JmPotato ghzpotato@gmail.com

What problem does this PR solve?

Add the feature requested in issue #2542

What is changed and how it works?

Add region_leaders field in SyncRegionResponse to pass the region's leader info between PD leader and follower. And the region leader changing will also trigger sync now to make the region leader info more accurate.

Check List

Tests

  • Unit test

Related changes

Release note

Sync region leaders between PD leader and followers rather than just waiting for heartbeats

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot added component/misc Some other things. contribution This PR is from a community contributor. type/cherry-pick labels Aug 13, 2020
@ti-srebot ti-srebot added this to the v4.0.6 milestone Aug 13, 2020
@ti-srebot
Copy link
Contributor Author

@JmPotato please accept the invitation then you can push to the cherry-pick pull requests.
https://github.com/ti-srebot/pd/invitations

@sre-bot
Copy link
Contributor

sre-bot commented Aug 13, 2020

Signed-off-by: JmPotato <ghzpotato@gmail.com>
@JmPotato JmPotato closed this Aug 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/misc Some other things. contribution This PR is from a community contributor.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants