syncer: sync region leaders between PD leader and follower (#2591) #2795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: JmPotato <ghzpotato@gmail.com>
Codecov Report
@@ Coverage Diff @@
## release-4.0 #2795 +/- ##
===============================================
+ Coverage 77.41% 77.44% +0.02%
===============================================
Files 206 206
Lines 22630 22652 +22
===============================================
+ Hits 17520 17542 +22
Misses 3790 3790
Partials 1320 1320
Continue to review full report at Codecov.
|
disksing
approved these changes
Aug 19, 2020
ti-srebot
approved these changes
Aug 19, 2020
|
/run-all-tests |
|
/merge |
ti-srebot
added
the
status/can-merge
|
/run-all-tests |
1 similar comment
|
/run-all-tests |
|
@JmPotato merge failed. |
|
/run-all-tests |
1 similar comment
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #2591 to release-4.0
Signed-off-by: JmPotato ghzpotato@gmail.com
What problem does this PR solve?
Add the feature requested in issue #2542
What is changed and how it works?
Add
region_leadersfield inSyncRegionResponseto pass the region's leader info between PD leader and follower. And the region leader changing will also trigger sync now to make the region leader info more accurate.Check List
Tests
Related changes
pingcap/kvprotoRelease note