Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log redact on TiFlash #5687

Merged
merged 5 commits into from
Mar 9, 2021
Merged

Log redact on TiFlash #5687

merged 5 commits into from
Mar 9, 2021

Conversation

JaySon-Huang
Copy link
Contributor

Signed-off-by: JaySon-Huang tshent@qq.com

First-time contributors' checklist

What is changed, added or deleted? (Required)

Add redact log configurations for TiFlash.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@JaySon-Huang
Log redact on TiFlash
7dad295 
Signed-off-by: JaySon-Huang <tshent@qq.com>
@JaySon-Huang
Fix link
b1e09f4 
Signed-off-by: JaySon-Huang <tshent@qq.com>
@JaySon-Huang
Fix link
ff8c969 
Signed-off-by: JaySon-Huang <tshent@qq.com>
@JaySon-Huang
Copy link
Contributor Author

The manual cherry-pick for the release-4.0 branch: #5688

@JaySon-Huang JaySon-Huang mentioned this pull request Mar 9, 2021
Closed
7 tasks
tisonkun
tisonkun approved these changes Mar 9, 2021
View reviewed changes
Copy link

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@ti-srebot
Copy link
Contributor

@tisonkun, Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments. See the corresponding SIG page for more information. Related SIG: docs(slack).

@TomShawn TomShawn added needs-cherry-pick-5.0 size/small Changes of a small size. translation/doing This PR’s assignee is translating this PR. labels Mar 9, 2021
TomShawn
TomShawn reviewed Mar 9, 2021
View reviewed changes
log-redaction.md Outdated Show resolved Hide resolved
TomShawn
TomShawn approved these changes Mar 9, 2021
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 9, 2021
@TomShawn TomShawn merged commit 04cb875 into pingcap:master Mar 9, 2021
ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Mar 9, 2021
@JaySon-Huang @ti-srebot
cherry pick pingcap#5687 to release-5.0
519aeb9 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Mar 9, 2021
Merged
11 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #5696

@JaySon-Huang JaySon-Huang deleted the tiflash_redact_log branch March 9, 2021 09:23
TomShawn added a commit that referenced this pull request Mar 9, 2021
@ti-srebot @JaySon-Huang @TomShawn
Log redact on TiFlash (#5687) (#5696)
fbfba40 
* cherry pick #5687 to release-5.0

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

* remove a pair of backticks

* add backticks

* remove 3 backticks

* add three backticks

* remove backticks

Co-authored-by: JaySon <tshent@qq.com>
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@Joyinqin Joyinqin mentioned this pull request Mar 10, 2021
Merged
11 tasks
@Joyinqin
Copy link
Contributor

/label translation/done

@ti-srebot ti-srebot added the translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. label Mar 10, 2021
@Joyinqin
Copy link
Contributor

/unlabel translation/doing

@ti-srebot ti-srebot removed the translation/doing This PR’s assignee is translating this PR. label Mar 10, 2021
@ti-srebot ti-srebot mentioned this pull request Mar 10, 2021
Merged
11 tasks
@Oreoxmt Oreoxmt mentioned this pull request Aug 31, 2022
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tisonkun tisonkun tisonkun approved these changes

@TomShawn TomShawn TomShawn approved these changes

Assignees

@Joyinqin Joyinqin

Labels
size/small Changes of a small size. status/LGT1 Indicates that a PR has LGTM 1. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@JaySon-Huang @ti-srebot @Joyinqin @tisonkun @TomShawn