Add TiFlash security configuration #5094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: JaySon-Huang <tshent@qq.com>
This was referenced Dec 15, 2020
JaySon-Huang
commented
Dec 15, 2020
TomShawn
reviewed
Dec 15, 2020
| @@ -85,6 +85,19 @@ delta_index_cache_size = 0 # DeltaIndex 内存 cache 大小限制，默认为 0 | |||
| dt_enable_logical_split = true # 存储引擎的 segment 分裂是否使用逻辑分裂。使用逻辑分裂可以减小写放大，提高写入速度，但是会造成一定的空间浪费。默认为 true | |||
| max_memory_usage = 0 # 单次 coprocessor 查询过程中，对中间数据的内存限制，单位为 byte，默认为 0，表示不限制 | |||
| max_memory_usage_for_all_queries = 0 # 所有查询过程中，对中间数据的内存限制，单位为 byte，默认为 0，表示不限制 | |||
|
|
|||
| ## 安全相关配置，从 v4.0.5 开始生效 | |||
There was a problem hiding this comment.
这里提到从 v4.0.5 开始生效，PR 是否需要 cherry-pick 到 release-4.0 呢？
There was a problem hiding this comment.
也钩上了 pick 到 4.0。
redact_info_log 这个配置项暂时没有进 v4.0.9 的版本中。pick 4.0 的时候暂时先不加这个配置项。
There was a problem hiding this comment.
可以 pick 到 4.0 后再删掉 redact_info_log，以后再加上？
TomShawn
added
size/small
flowbehappy
reviewed
Dec 16, 2020
Co-authored-by: Flowyi <flowbehappy@gmail.com>
|
@flowbehappy, Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments. See the corresponding SIG page for more information. Related SIG: docs(slack). |
TomShawn
reviewed
Dec 17, 2020
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
TomShawn
added
the
requires-version-specific-changes
ti-srebot
pushed a commit
to ti-srebot/docs-cn
that referenced
this pull request
Dec 18, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
10 tasks
|
cherry pick to release-4.0 in PR #5130 |
10 tasks
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: JaySon-Huang tshent@qq.com
First-time contributors' checklist
What is changed, added or deleted? (Required)
Add document for security configuration in TiFlash.
Which TiDB version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?