Log redact on TiFlash #4994
Merged
Log redact on TiFlash #4994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/label needs-cherry-pick-5.0, translation/from-docs-cn |
ti-srebot
added
needs-cherry-pick-5.0
translation/from-docs-cn
log-redaction.md
Outdated
| @@ -44,3 +44,7 @@ To enable log redaction in the TiKV side, set the value of [`security.redact-inf | |||
| ## Log redaction in PD side | |||
|
|
|||
| To enable log redaction in the PD side, set the value of [`security.redact-info-log`](/pd-configuration-file.md#redact-info-log-new-in-v500-rc) to `true`. This configuration value defaults to `false`, which means that log redaction is disabled. | |||
|
|
|||
| ## Log desensitization of TiFlash components | |||
There was a problem hiding this comment.
Use the word "redaction" instead of "desensitization" to make it aligned with other components?
…into tiflash-redact-log
Co-authored-by: JaySon <jayson.hjs@gmail.com>
ti-srebot
pushed a commit
to ti-srebot/docs
that referenced
this pull request
Mar 10, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
11 tasks
|
cherry pick to release-5.0 in PR #4998 |
| @@ -153,10 +153,9 @@ delta_index_cache_size = 0 | |||
|
|
|||
| ## Security settings take effect starting from v4.0.5. | |||
| [security] | |||
| ## This configuration item enables or disables log redaction. If the configuration value | |||
| ## New in v5.0.0-rc. This configuration item enables or disables log redaction. If the configuration value | |||
There was a problem hiding this comment.
Make these two aligned? Make it both "New in v5.0.0-rc" or "New in v4.0.10"
|
|
||
| ## Specifies the shortest interval at which Raft store persists WAL. | ||
| ## You can properly increase the latency to reduce IOPS usage. | ||
| ## The default value is "4ms". | ||
| ## If you set it to 0ms, the optimization is disabled. | ||
| store-batch-retry-recv-timeout = "4ms" | ||
| [security] | ||
| ## New in v4.0.10. This configuration item enables or disables log redaction. |
TomShawn
added a commit
that referenced
this pull request
Mar 10, 2021
* cherry pick #4994 to release-5.0 Signed-off-by: ti-srebot <ti-srebot@pingcap.com> * Update tiflash/tiflash-configuration.md Co-authored-by: JoyinQ <56883733+Joyinqin@users.noreply.github.com> Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First-time contributors' checklist
What is changed, added or deleted? (Required)
Add redact log configurations for TiFlash.
Which TiDB version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?