Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev: update sql admin syntax #2204

Merged
merged 14 commits into from
Feb 13, 2020
Merged

dev: update sql admin syntax #2204

merged 14 commits into from
Feb 13, 2020

Conversation

crazycs520
Copy link
Contributor

@crazycs520 crazycs520 commented Feb 3, 2020 •
edited by TomShawn
Loading

What is changed, added or deleted?

Update admin syntax for TiDB 4.0.

What is the related PR or file link(s)?

Which TiDB version(s) does your changes apply to?

  • All active versions: dev, v3.0, v2.1, v3.1
  • dev (the latest development version)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)
  • v3.1 (TiDB 3.1 versions)
  • v4.0 (TiDB 4.0 versions)

Note: If your changes apply to multiple TiDB versions, make sure you update the documents in the corresponding version folders such as "dev", "v3.0", "v2.1" and "v3.1" in this PR.

  • Updated one version first. Will update other versions after I get two LGTMs.

AilinKid
AilinKid reviewed Feb 3, 2020
View reviewed changes
Copy link
Contributor

@AilinKid AilinKid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

dev/reference/sql/statements/admin.md Outdated Show resolved Hide resolved
dev/reference/sql/statements/admin.md Outdated Show resolved Hide resolved
crazycs520 and others added 2 commits February 3, 2020 14:52
@crazycs520 @AilinKid
Update dev/reference/sql/statements/admin.md
933d8af 
Co-Authored-By: Arenatlx <ailinsilence4@gmail.com>
@crazycs520 @AilinKid
Update dev/reference/sql/statements/admin.md
7ba75c0 
Co-Authored-By: Arenatlx <ailinsilence4@gmail.com>
zimulala
zimulala reviewed Feb 3, 2020
View reviewed changes
Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crazycs520 crazycs520 added v4.0 This PR/issue applies to TiDB v4.0. dev labels Feb 3, 2020
@crazycs520
Copy link
Contributor Author

@lilin90 PTAL

@TomShawn TomShawn added the translation/doing This PR’s assignee is translating this PR. label Feb 4, 2020
lilin90
lilin90 reviewed Feb 5, 2020
View reviewed changes
dev/reference/sql/statements/admin.md Outdated Show resolved Hide resolved
dev/reference/sql/statements/admin.md Outdated Show resolved Hide resolved
dev/reference/sql/statements/admin.md Show resolved Hide resolved
dev/reference/sql/statements/admin.md Outdated Show resolved Hide resolved
dev/reference/sql/statements/admin.md Outdated Show resolved Hide resolved
dev/reference/sql/statements/admin.md Outdated Show resolved Hide resolved
crazycs520 and others added 5 commits February 6, 2020 14:56
@crazycs520 @lilin90
Update dev/reference/sql/statements/admin.md
1aa254f 
Co-Authored-By: Lilian Lee <lilin@pingcap.com>
@crazycs520 @lilin90
Update dev/reference/sql/statements/admin.md
60cb0c9 
Co-Authored-By: Lilian Lee <lilin@pingcap.com>
@crazycs520 @lilin90
Update dev/reference/sql/statements/admin.md
f47d07c 
Co-Authored-By: Lilian Lee <lilin@pingcap.com>
@crazycs520
address comment
b47dc91 
Signed-off-by: crazycs <crazycs520@gmail.com>
@crazycs520
Merge branch 'master' into admin-ddl
6d006f7
@bb7133
Copy link
Member

bb7133 commented Feb 10, 2020

PTAL @lilin90

@bb7133 bb7133 added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 10, 2020
lilin90
lilin90 reviewed Feb 10, 2020
View reviewed changes
Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try to make the description clearer. Rest LGTM.

dev/reference/sql/statements/admin.md Outdated Show resolved Hide resolved
dev/reference/sql/statements/admin.md Outdated Show resolved Hide resolved
dev/reference/sql/statements/admin.md Outdated Show resolved Hide resolved
crazycs520 and others added 5 commits February 12, 2020 10:31
@crazycs520 @lilin90
Update dev/reference/sql/statements/admin.md
9e5c14d 
Co-Authored-By: Lilian Lee <lilin@pingcap.com>
@crazycs520 @lilin90
Update dev/reference/sql/statements/admin.md
e298fd6 
Co-Authored-By: Lilian Lee <lilin@pingcap.com>
@crazycs520 @lilin90
Update dev/reference/sql/statements/admin.md
bb5c481 
Co-Authored-By: Lilian Lee <lilin@pingcap.com>
@crazycs520
add end time
270245e 
Signed-off-by: crazycs <crazycs520@gmail.com>
@crazycs520
Merge branch 'master' into admin-ddl
799f273
lilin90
lilin90 approved these changes Feb 13, 2020
View reviewed changes
Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lilin90 lilin90 added DNM and removed DNM labels Feb 13, 2020
@lilin90 lilin90 added the status/can-merge Indicates a PR has been approved by a committer. label Feb 13, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Feb 13, 2020

/run-all-tests

@lilin90 lilin90 added the size/small Changes of a small size. label Feb 13, 2020
@sre-bot sre-bot merged commit 818f72f into pingcap:master Feb 13, 2020
@ran-huang ran-huang added aligning and removed translation/doing This PR’s assignee is translating this PR. labels Feb 13, 2020
@ran-huang ran-huang mentioned this pull request Feb 13, 2020
Merged
12 tasks
@ran-huang ran-huang added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed aligning labels Feb 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zimulala zimulala zimulala left review comments

@AilinKid AilinKid AilinKid left review comments

@lilin90 lilin90 lilin90 approved these changes

Assignees

@ran-huang ran-huang

Labels
size/small Changes of a small size. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. v4.0 This PR/issue applies to TiDB v4.0.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@crazycs520 @bb7133 @sre-bot @zimulala @AilinKid @lilin90 @TomShawn @ran-huang