Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reference: update sql admin syntax #1811

Merged
merged 9 commits into from
Feb 17, 2020
Merged

reference: update sql admin syntax #1811

merged 9 commits into from
Feb 17, 2020

Conversation

ran-huang
Copy link
Contributor

What is changed, added or deleted?

Update admin syntax for TiDB 4.0.

What is the related PR or file link(s)?

Which TiDB version(s) does your changes apply to?

  • All active versions: dev, v3.0, v2.1, v3.1
  • dev (the latest development version)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)
  • v3.1 (TiDB 3.1 versions)
  • v4.0 (TiDB 4.0 versions)
  • All active and inactive versions
  • N/A (not applicable)

Note: If your changes apply to multiple TiDB versions, make sure you update the documents in the corresponding version folders such as "dev", "v3.0", "v2.1" and "v3.1" in this PR.

  • Updated one version first. Will update other versions after I get two LGTMs.

@ran-huang ran-huang added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. dev v4.0 This PR/issue applies to TiDB v4.0. labels Feb 13, 2020
dev/reference/sql/statements/admin.md Outdated Show resolved Hide resolved
dev/reference/sql/statements/admin.md Show resolved Hide resolved
dev/reference/sql/statements/admin.md Show resolved Hide resolved
dev/reference/sql/statements/admin.md Outdated Show resolved Hide resolved
dev/reference/sql/statements/admin.md Outdated Show resolved Hide resolved
dev/reference/sql/statements/admin.md Outdated Show resolved Hide resolved
dev/reference/sql/statements/admin.md Outdated Show resolved Hide resolved
ran-huang and others added 5 commits February 14, 2020 16:03
Co-Authored-By: Lilian Lee <lilin@pingcap.com>
Co-Authored-By: Lilian Lee <lilin@pingcap.com>
Co-Authored-By: Lilian Lee <lilin@pingcap.com>
Co-Authored-By: Lilian Lee <lilin@pingcap.com>
@ran-huang
Copy link
Contributor Author

Committed all the suggestions. PTAL~ @lilin90

dev/reference/sql/statements/admin.md Show resolved Hide resolved
dev/reference/sql/statements/admin.md Outdated Show resolved Hide resolved
dev/reference/sql/statements/admin.md Outdated Show resolved Hide resolved
lilin90 and others added 3 commits February 17, 2020 17:39
Co-Authored-By: Lilian Lee <lilin@pingcap.com>
Co-Authored-By: Lilian Lee <lilin@pingcap.com>
@ran-huang
Copy link
Contributor Author

@lilin90 PTAL~

Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @crazycs520 PTAL~ Thanks!

Copy link
Contributor

@crazycs520 crazycs520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ran-huang ran-huang merged commit 9de68b9 into pingcap:master Feb 17, 2020
@ran-huang ran-huang deleted the align-2204 branch February 17, 2020 10:33
sticnarf pushed a commit to sticnarf/docs that referenced this pull request Mar 20, 2020
* reference: update sql admin syntax

* Update dev/reference/sql/statements/admin.md

Co-Authored-By: Lilian Lee <lilin@pingcap.com>

* Update dev/reference/sql/statements/admin.md

Co-Authored-By: Lilian Lee <lilin@pingcap.com>

* Update dev/reference/sql/statements/admin.md

Co-Authored-By: Lilian Lee <lilin@pingcap.com>

* Apply suggestions from code review

Co-Authored-By: Lilian Lee <lilin@pingcap.com>

* Move the command explanation forward

* reference: modify capitalization after colons

Co-Authored-By: Lilian Lee <lilin@pingcap.com>

* reference: add a new line

Co-Authored-By: Lilian Lee <lilin@pingcap.com>

Co-authored-by: Lilian Lee <lilin@pingcap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. v4.0 This PR/issue applies to TiDB v4.0.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants