Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Form): add novalidate flag to form #1253

Merged
merged 1 commit into from
Jan 28, 2019

Conversation

kmcfaul
Copy link
Contributor

@kmcfaul kmcfaul commented Jan 25, 2019

What: adding novalidate flag to form to match core. It's possible that a core update might also be required but I wasn't seeing the error anymore locally.

Refer to issue: #1039

@kmcfaul kmcfaul requested review from tlabaj, mcoker and jschuler January 25, 2019 19:41
@patternfly-build
Copy link
Contributor

PatternFly-React preview: https://1253-pr-patternfly-react-patternfly.surge.sh

@coveralls
Copy link

Pull Request Test Coverage Report for Build 4128

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 80.368%

Totals Coverage Status
Change from base Build 4120: 0.0%
Covered Lines: 4552
Relevant Lines: 5329

💛 - Coveralls

Copy link
Contributor

@mcoker mcoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants