Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Form): add novalidate flag to form #1253

Merged
merged 1 commit into from
Jan 28, 2019
Merged

feat(Form): add novalidate flag to form #1253

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/patternfly-4/react-core/src/components/Form/Form.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ const defaultProps = {
};

const Form = ({ className, children, isHorizontal, ...props }) => (
<form {...props} className={css(styles.form, isHorizontal && styles.modifiers.horizontal, className)}>
<form noValidate {...props} className={css(styles.form, isHorizontal && styles.modifiers.horizontal, className)}>
<FormContext.Provider value={{ isHorizontal }}>{children}</FormContext.Provider>
</form>
);
Expand Down
1 change: 1 addition & 0 deletions packages/patternfly-4/react-core/src/components/Form/__snapshots__/ActionGroup.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ exports[`ActionGroup component should render horizontal form ActionGroup variant
>
<form
className="pf-c-form pf-m-horizontal"
noValidate={true}
>
<ActionGroup
className=""
Expand Down
2 changes: 2 additions & 0 deletions packages/patternfly-4/react-core/src/components/Form/__snapshots__/Form.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ exports[`Form component should render default form variant 1`] = `

<form
className="pf-c-form"
noValidate={true}
>
<[object Object]
value={
Expand All @@ -27,6 +28,7 @@ exports[`Form component should render horizontal form variant 1`] = `

<form
className="pf-c-form pf-m-horizontal"
noValidate={true}
>
<[object Object]
value={
Expand Down
1 change: 1 addition & 0 deletions packages/patternfly-4/react-core/src/components/Form/__snapshots__/FormGroup.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -491,6 +491,7 @@ exports[`FormGroup component should render horizontal form group variant 1`] = `
>
<form
className="pf-c-form pf-m-horizontal"
noValidate={true}
>
<FormGroup
className=""
Expand Down