Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Form: Required fields behave incorrectly on Firefox #1039

Closed
mcarrano opened this issue Dec 12, 2018 · 4 comments
Closed

Form: Required fields behave incorrectly on Firefox #1039

mcarrano opened this issue Dec 12, 2018 · 4 comments
Assignees
Milestone

Comments

@mcarrano
Copy link
Member

I reviewing the Form component I find that required fields display with a red border on form load when viewed in Firefox. Fields should only validate on loss of focus or upon clicking the Submit button. Here an example of what this looks like:

screen shot 2018-12-12 at 11 41 09 am

There is a related issue here: #986

@rachael-phillips
Copy link
Contributor

Being investigated in Core

@mcoker
Copy link
Contributor

mcoker commented Jan 25, 2019

This was resolved in core workspace, but isn't a CSS fix, so we'll need to make the same updates in react. We just replaced all instances of <form with <form novalidate, to disable the HTML5 browser validation. Here's the PR with the changes made in core - https://github.com/patternfly/patternfly-next/pull/1299/files

@rachael-phillips
Copy link
Contributor

Can we close this?

@dlabaj
Copy link
Contributor

dlabaj commented Jan 28, 2019

Closing fixed in #1253

@dlabaj dlabaj closed this as completed Jan 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants