Add the ability to build a pex to the release script #5159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
jsirois
approved these changes
Dec 5, 2017
stuhood
pushed a commit
that referenced
this pull request
Dec 13, 2017
### Problem The wheels built in #5118 and consumed in #5159 are built in debian wheezy, meaning that they have a glibc 2.13 dependency... centos6 (still consumed in various places at Twitter) uses glibc 2.12. More generally, it is beneficial to have binary releases of pants be compatible with as many linux distributions as possible (those that are in active use, at least). ### Solution Add a centos6 docker image, which was previously confirmed here to be capable of building pants. ### Result In a future change (once this image is published to https://hub.docker.com/r/pantsbuild/), we will switch the linux binary builder shard (`build-support/docker/travis_ci/Dockerfile`) to this image.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We're building cross-platform wheels for pants and its dependencies in CI, but we don't yet have the ability to consume them to build a pex.
Solution
Add the ability to consume the cross platform wheels to build a pex.
Result
The resulting pex works on
centos7andosx, but does not yet work oncentos6due to older GLIBC. So the next steps will be to: