Add a centos6 Dockerfile #5167
Merged
Add a centos6 Dockerfile #5167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuhood
force-pushed
the
stuhood/centos6
branch
2 times, most recently
from
a8c6dc2
to
f84795d
Compare
stuhood
force-pushed
the
stuhood/centos6
branch
from
64d68b1
to
3654001
Compare
stuhood
changed the title
kwlzn
approved these changes
Dec 12, 2017
|
|
||
| # TODO: Not https? Now we're really doing some science! | ||
| RUN curl -o /etc/yum.repos.d/slc6-devtoolset.repo http://linuxsoft.cern.ch/cern/devtoolset/slc6-devtoolset.repo | ||
| RUN rpm --import http://linuxsoft.cern.ch/cern/slc6X/x86_64/RPM-GPG-KEY-cern |
There was a problem hiding this comment.
sketchy.. but not actually required, afaict? I'm able to yum install all of the below without this.
| FROM centos:6 | ||
|
|
||
| # Ensure Pants runs under the 2.7.13 interpreter. | ||
| ENV PANTS_PYTHON_SETUP_INTERPRETER_CONSTRAINTS="['CPython==2.7.13']" |
There was a problem hiding this comment.
can always pass this in at runtime vs hardcoding in the image build, fwiw.
This was referenced Dec 13, 2017
Closed
stuhood
pushed a commit
that referenced
this pull request
Dec 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The wheels built in #5118 and consumed in #5159 are built in debian wheezy, meaning that they have a glibc 2.13 dependency... centos6 (still consumed in various places at Twitter) uses glibc 2.12.
More generally, it is beneficial to have binary releases of pants be compatible with as many linux distributions as possible (those that are in active use, at least).
Solution
Add a centos6 docker image, which was previously confirmed here to be capable of building pants.
Result
In a future change (once this image is published to https://hub.docker.com/r/pantsbuild/), we will switch the linux binary builder shard (
build-support/docker/travis_ci/Dockerfile) to this image.