Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the ability to build a pex to the release script #5159

Merged
merged 2 commits into from
Dec 5, 2017
Merged

Add the ability to build a pex to the release script #5159

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
02b47eb
Add the ability to build a pex to the release script.
stuhood Dec 5, 2017
513c8e7
Fix typo
stuhood Dec 5, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
70 changes: 53 additions & 17 deletions build-support/bin/release.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -619,17 +619,6 @@ function fetch_and_check_prebuilt_wheels() {
missing+=("${NAME} (expected whls for each platform: had only ${packages[@]})")
continue
fi

# Here we re-name the linux platform specific wheels we build to masquerade as manylinux1
# compatible wheels. We take care to support this when we generate the wheels and pypi will
# only accept manylinux1 linux binary wheels.
for package in "${packages[@]}"
do
if [[ "${package}" =~ "-linux_" ]]
then
mv -v "${package}" "${package/-linux_/-manylinux1_}"
fi
done
done

if (( ${#missing[@]} > 0 ))
Expand All @@ -643,6 +632,20 @@ function fetch_and_check_prebuilt_wheels() {
fi
}

function adjust_wheel_platform() {
# Renames wheels to adjust their tag from a src platform to a dst platform.
# TODO: pypi will only accept manylinux wheels, but pex does not support manylinux whls:
# this function is used to go in one direction or another, depending on who is consuming.
# see https://github.com/pantsbuild/pants/issues/4956
local src_plat="$1"
local dst_plat="$2"
local dir="$3"
for src_whl in `find "${dir}" -name '*'"${src_plat}.whl"`; do
local dst_whl=${src_whl/$src_plat/$dst_plat}
mv -f "${src_whl}" "${dst_whl}"
done
}

function activate_twine() {
local readonly venv_dir="${ROOT}/build-support/twine-deps.venv"

Expand All @@ -652,6 +655,34 @@ function activate_twine() {
pip install twine
}

function build_pex() {
# Builds a pex from the current UNSTABLE version.

local linux_platform="linux_x86_64"

rm -rf "${DEPLOY_DIR}"
mkdir -p "${DEPLOY_DIR}"
fetch_and_check_prebuilt_wheels "${DEPLOY_DIR}"
adjust_wheel_platform "manylinux1_x86_64" "${linux_platform}" "${DEPLOY_DIR}"

local dest="${ROOT}/dist/pants.${PANTS_UNSTABLE_VERSION}.pex"

activate_tmp_venv && trap deactivate RETURN && pip install "pex==1.2.13" || die "Failed to install pex."

pex \
-o "${dest}" \
--entry-point="pants.bin.pants_loader:main" \
--no-build \
--no-pypi \
--disable-cache \
--platform="macosx_10.10_x86_64" \
--platform="${linux_platform}" \
-f "${DEPLOY_PANTS_WHEEL_DIR}/${PANTS_UNSTABLE_VERSION}" \
-f "${DEPLOY_3RDPARTY_WHEEL_DIR}/${PANTS_UNSTABLE_VERSION}" \
"pantsbuild.pants==${PANTS_UNSTABLE_VERSION}"

}

function publish_packages() {
# TODO(John Sirois): Remove sdist generation and twine upload when
# https://github.com/pantsbuild/pants/issues/4956 is resolved.
Expand All @@ -664,8 +695,11 @@ function publish_packages() {

start_travis_section "Publishing" "Publishing packages for ${PANTS_STABLE_VERSION}"

# Fetch unstable wheels, and then reversion them from PANTS_UNSTABLE_VERSION to PANTS_STABLE_VERSION.
# Fetch unstable wheels, rename any linux whls to manylinux, and reversion them
# from PANTS_UNSTABLE_VERSION to PANTS_STABLE_VERSION
fetch_and_check_prebuilt_wheels "${DEPLOY_DIR}"
adjust_wheel_platform "linux_x86_64" "manylinux1_x86_64" \
"${DEPLOY_PANTS_WHEEL_DIR}/${PANTS_UNSTABLE_VERSION}"
reversion_whls \
"${DEPLOY_PANTS_WHEEL_DIR}/${PANTS_UNSTABLE_VERSION}" \
"${DEPLOY_PANTS_WHEEL_DIR}/${PANTS_STABLE_VERSION}" \
Expand All @@ -685,7 +719,7 @@ function usage() {
echo "PyPi. Credentials are needed for this as described in the"
echo "release docs: http://pantsbuild.org/release.html"
echo
echo "Usage: $0 [-d] [-c] (-h|-n|-t|-l|-o|-e)"
echo "Usage: $0 [-d] [-c] (-h|-n|-t|-l|-o|-e|-p)"
echo " -d Enables debug mode (verbose output, script pauses after venv creation)"
echo " -h Prints out this help message."
echo " -n Performs a release dry run."
Expand All @@ -700,6 +734,7 @@ function usage() {
echo " -l Lists all pantsbuild packages that this script releases."
echo " -o Lists all pantsbuild package owners."
echo " -e Check that wheels are prebuilt for this release."
echo " -p Build a pex from prebuilt wheels for this release."
echo
echo "All options (except for '-d' and '-c') are mutually exclusive."

Expand All @@ -710,16 +745,17 @@ function usage() {
fi
}

while getopts "hdntcloe" opt; do
while getopts "hdntcloep" opt; do
case ${opt} in
h) usage ;;
d) debug="true" ;;
n) dry_run="true" ;;
t) test_release="true" ;;
c) core_only="true" ;;
l) list_packages && exit 0 ;;
o) list_owners && exit 0 ;;
e) fetch_and_check_prebuilt_wheels && exit 0 ;;
l) list_packages ; exit $? ;;
o) list_owners ; exit $? ;;
e) fetch_and_check_prebuilt_wheels ; exit $? ;;
p) build_pex ; exit $? ;;
*) usage "Invalid option: -${OPTARG}" ;;
esac
done
Expand Down