convert ~all of the ctypes integration tests to unit tests in the native backend #7128
Comments
This was referenced Jan 23, 2019
Merged
This was referenced Feb 22, 2019
cosmicexplorer
added a commit
that referenced
this issue
Mar 3, 2019
) ### Problem We want to do #7128, which involves adding some more C/C++ unit testing. We would love to use some of the declarative task specification stuff we've added to the `python_dist()` testing to do that. ### Solution - Move the generic logic out of `BuildLocalPythonDistributionsTestBase` into `DeclarativeTaskTestMixin` in `task_test_base.py`. ### Result A new interface for task unit testing (which can be extended to more than just v1 tasks) is available to other testing.
|
Tests will be deleted soon in Pants 2.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Most of the tests in
test_ctypes_integration.pyare flaky (see #6886) or at best extremely slow (sorry about that!!! won't happen again). In #7126 we convert almost all of thepython_dist()integration tests into unit tests, which also removes > 500 lines of code. After some practice with task unit testing in that PR, it's extremely clear that we should do the same with ctypes (this wasn't done in #7126 because it was already big enough).We should also make sure to whittle down the
dependenciesin the ctypes test targets, as they were copied verbatim fromtests/python/pants_test/backend/python/tasks/BUILDto ease the transition from supporting use of the native toolchain for compiling distutilsExtensions (which was EOLed in #7126).The text was updated successfully, but these errors were encountered: