Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add toolchain_variant on native target level #7179

Merged
merged 14 commits into from
Jan 31, 2019
Merged

Add toolchain_variant on native target level #7179

merged 14 commits into from
Jan 31, 2019

Conversation

wisechengyi
Copy link
Contributor

@wisechengyi wisechengyi commented Jan 29, 2019 •
edited
Loading

Resolves #7122

@wisechengyi wisechengyi changed the title wip 7122 Add toolchain_variant on target level Jan 29, 2019
@wisechengyi wisechengyi changed the title Add toolchain_variant on target level Add toolchain_variant on native target level Jan 29, 2019
@wisechengyi
Copy link
Contributor Author

Thanks! ready for review.

@cosmicexplorer cosmicexplorer mentioned this pull request Jan 30, 2019
Closed
cosmicexplorer
cosmicexplorer requested changes Jan 30, 2019
View reviewed changes
Copy link
Contributor

@cosmicexplorer cosmicexplorer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for diving into this! This is on the whole great, only a small change is necessary to get the option value precedence set up for eventually fixing #7183. This is a really great step towards making the native backend scale to more than single projects.

tests/python/pants_test/backend/native/tasks/test_cpp_compile.py Show resolved Hide resolved
src/python/pants/backend/native/subsystems/native_build_step_settings.py Outdated Show resolved Hide resolved
src/python/pants/backend/native/tasks/native_task.py Outdated Show resolved Hide resolved
src/python/pants/backend/native/tasks/native_task.py Show resolved Hide resolved
cosmicexplorer
cosmicexplorer approved these changes Jan 31, 2019
View reviewed changes
Copy link
Contributor

@cosmicexplorer cosmicexplorer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you!

@cosmicexplorer cosmicexplorer merged commit 56bc988 into pantsbuild:master Jan 31, 2019
@wisechengyi wisechengyi deleted the issue7122 branch January 31, 2019 19:23
cosmicexplorer pushed a commit to twitter/pants that referenced this pull request Jan 31, 2019
@wisechengyi @cosmicexplorer
Add toolchain_variant on native target level (pantsbuild#7179)
8c3d03e 
Resolves pantsbuild#7122
@cosmicexplorer cosmicexplorer mentioned this pull request Jan 31, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cosmicexplorer cosmicexplorer cosmicexplorer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wisechengyi @cosmicexplorer