move the declarative task stuff out of the python backend testing #7279
Conversation
cosmicexplorer
requested review from
stuhood,
jsirois,
CMLivingston and
Eric-Arellano
| single_product = all_products[0] | ||
| return single_product | ||
|
|
||
| def _create_task(self, task_type, context): |
There was a problem hiding this comment.
TaskTestBase should handle this I think.
There was a problem hiding this comment.
Added a docstring -- this is used specifically to hydrate the run_before_task_types and run_after_task_types in self.invoke_tasks().
|
Should have addressed the comments above, and finally managed to get a green CI run! |
| raise NotImplementedError('dist_specs must be implemented!') | ||
|
|
||
| @classproperty | ||
| def run_before_task_types(cls): |
There was a problem hiding this comment.
The run_before and run_after tasks look very important for correct usage of this class, but it's not clear to me what they would do (without reading the implementation of this class).
There was a problem hiding this comment.
Added lots more documentation (and removed the previous docstrings)!
| """Tasks to run after local dists are built, similar to `run_before_task_types`.""" | ||
| return [] | ||
|
|
||
| def populate_target_dict(self): |
There was a problem hiding this comment.
This helper method doesn't seem like it is specific to this class. You could probably pass in the dist_specs as a map, and return the created targets (which you could then pass to invoke_tasks). That would allow the method to move up to TestBase, and make it useful in more places.
The rest of the Task manipulation stuff could probably stay here.
tests/python/pants_test/test_base.py
Outdated
|
|
||
| The values of `target_map` should themselves be a flat dict, which contains keyword arguments | ||
| fed into `self.make_target()`, along with a few special keys. Special keys are: | ||
| - 'key' (required -- used to index into the returned dict). |
There was a problem hiding this comment.
Could this be an address, or address string?
There was a problem hiding this comment.
It could default to that, actually -- the idea was to decouple accessing the target from within testing from its specific address so you could use a test class-specific shorthand.
There was a problem hiding this comment.
It now defaults to the target address string!
cosmicexplorer
force-pushed
the
make-ctypes-tests-unit-tests
branch
from
187d7ff
to
c6a4031
Compare
Problem
We want to do #7128, which involves adding some more C/C++ unit testing. We would love to use some of the declarative task specification stuff we've added to the
python_dist()testing to do that.Solution
BuildLocalPythonDistributionsTestBaseintoDeclarativeTaskTestMixinintask_test_base.py.Result
A new interface for task unit testing (which can be extended to more than just v1 tasks) is available to other testing.