[debatable] Hide left sidebar if no navitems present #5149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kulmann
suggested changes
May 25, 2021
packages/web-runtime/src/App.vue
Outdated
| @@ -220,6 +220,10 @@ export default { | |||
| return 'uk-visible@l' | |||
| }, | |||
|
|
|||
| isSidebarItems() { | |||
| return this.sidebarNavItems.length > 0 | |||
There was a problem hiding this comment.
Please add
if (this.sidebarNavItems.length === 0) {
return false
}to isSidebarVisible instead.
There was a problem hiding this comment.
Would like to move towards early returns in code style.
There was a problem hiding this comment.
Code is updated to reflect this 🤓
pascalwengerter
force-pushed
the
25052021_hide-left-sidebar-if-no-navitems
branch
2 times, most recently
from
fb16acc to
d8eab2e
Compare
pascalwengerter
force-pushed
the
25052021_hide-left-sidebar-if-no-navitems
branch
from
d8eab2e to
e4287f8
Compare
kulmann
approved these changes
May 25, 2021
delete-merged-branch
bot
deleted the
25052021_hide-left-sidebar-if-no-navitems
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Felt surprisingly easy, I'd vote in favor of only hiding the navigation (and not the whole sidebar) to keep the iconic CI blue plus OC logo present for public links though...