Hide left sidebar if no navitems present

owncloud · May 25, 2021 · fb16acc · fb16acc
1 parent a1fbd67
commit fb16acc
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/changelog/unreleased/enhancement-hide-navbar-if-no-navitems b/changelog/unreleased/enhancement-hide-navbar-if-no-navitems
@@ -0,0 +1,7 @@
+Enhancement: Hide left sidebar if no navitems are present
+
+For extensions / pages without nav items and public link pages, 
+we now hide the left sidebar to not confuse screen readers and 
+give more screen space for the content.
+
+https://github.com/owncloud/web/pull/5149
diff --git a/packages/web-runtime/src/App.vue b/packages/web-runtime/src/App.vue
@@ -18,7 +18,7 @@
     </template>
     <div v-else id="web-content" key="core-content" class="uk-flex uk-flex-stretch">
       <transition :name="appNavigationAnimation">
-        <focus-trap v-if="isSidebarVisible" :active="isSidebarFixed && appNavigationVisible">
+        <focus-trap v-if="isSidebarVisible && isSidebarItems" :active="isSidebarFixed && appNavigationVisible">
           <oc-sidebar-nav
             v-show="isSidebarVisible"
             id="web-nav-sidebar"
@@ -220,6 +220,13 @@ export default {
       return 'uk-visible@l'
     },
 
+    isSidebarItems() {
+      if (this.sidebarNavItems.length === 0) {
+        return false
+      }
+      return true
+    },
+
     isSidebarFixed() {
       return this.windowWidth <= 960
     },