Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[debatable] Hide left sidebar if no navitems present #5149

Merged
merged 1 commit into from
May 25, 2021
Merged

[debatable] Hide left sidebar if no navitems present #5149

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions changelog/unreleased/enhancement-hide-navbar-if-no-navitems
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
Enhancement: Hide left sidebar if no navitems are present

For extensions / pages without nav items and public link pages,
we now hide the left sidebar to not confuse screen readers and
give more screen space for the content.

https://github.com/owncloud/web/pull/5149
3 changes: 3 additions & 0 deletions packages/web-runtime/src/App.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,6 +225,9 @@ export default {
},

isSidebarVisible() {
if (this.sidebarNavItems.length === 0) {
return false
}
return this.windowWidth >= 1200 || this.appNavigationVisible
},

Expand Down