Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add more padding to input with text #12055

Merged
merged 1 commit into from
Dec 23, 2024

Conversation

LukasHirt
Copy link
Collaborator

Description

We've fixed the issue where the clear action of the text input would overlap the text entered into the input. When the clear action becomes visible, the right padding of the input will be increased by the size of the clear action.

Related Issue

Motivation and Context

Text and clear action are not overlapping each other and everything is clearly visible.

How Has This Been Tested?

  • test environment: chrome
  • test case 1: Enter long enough string into the input

Screenshots (if appropriate):

Zaznam.obrazovky.2024-12-23.v.11.48.49.mov

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests
  • Documentation
  • Maintenance (e.g. dependency updates or tooling)

@LukasHirt LukasHirt added the Type:Bug Something isn't working label Dec 23, 2024
@LukasHirt LukasHirt requested a review from saw-jan December 23, 2024 10:54
@LukasHirt LukasHirt self-assigned this Dec 23, 2024
@LukasHirt LukasHirt enabled auto-merge December 23, 2024 11:14
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@LukasHirt LukasHirt merged commit 0d13368 into master Dec 23, 2024
4 checks passed
@LukasHirt LukasHirt deleted the fix/input-clear-action-padding branch December 23, 2024 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type:Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ScienceMesh: Improve alignment of token and X in accept invitation
2 participants