Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add more padding to input with text #12055

Merged
merged 1 commit into from
Dec 23, 2024
Merged

fix: add more padding to input with text #12055

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions ...og/unreleased/bugfix-add-more-padding-to-input-when-clear-actions-is-visible.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
Bugfix: Add more padding to input when clear action is visible

We've fixed the issue where the clear action of the text input would overlap the text entered into the input. When the clear action becomes visible, the right padding of the input will be increased by the size of the clear action.

https://github.com/owncloud/web/pull/12055
https://github.com/owncloud/web/issues/11543
7 changes: 6 additions & 1 deletion packages/design-system/src/components/OcTextInput/OcTextInput.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,8 @@
:class="{
'oc-text-input-warning': !!warningMessage,
'oc-text-input-danger': !!errorMessage,
'oc-pl-l': !!readOnly
'oc-pl-l': !!readOnly,
'clear-action-visible': showClearButton
}"
:type="type"
:value="displayValue"
Expand Down Expand Up @@ -408,6 +409,10 @@ export default defineComponent({
margin-top: var(--oc-space-xsmall);
min-height: $oc-font-size-default * 1.5;
}

&.clear-action-visible {
padding-right: ($oc-size-icon-default * 0.7) + 7px;
}
}
</style>

Expand Down