-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tests-only] Adjust public link tests for download, upload and other operations #37552
Conversation
Codecov Report
@@ Coverage Diff @@
## master #37552 +/- ##
============================================
- Coverage 64.67% 64.66% -0.02%
- Complexity 19339 19343 +4
============================================
Files 1279 1279
Lines 75573 75600 +27
Branches 1331 1333 +2
============================================
+ Hits 48880 48885 +5
- Misses 26301 26323 +22
Partials 392 392
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #37552 +/- ##
=========================================
Coverage 64.70% 64.70%
Complexity 19353 19353
=========================================
Files 1281 1281
Lines 75612 75612
Branches 1333 1333
=========================================
Hits 48925 48925
Misses 26295 26295
Partials 392 392
Continue to review full report at Codecov.
|
3831752
to
dbfa573
Compare
Squashed and pushed. Added some more tickets and excluded tests. Still, I managed to enable a bunch of tests for public link upload, download, creation, etc. Updating and deleting is not implemented yet. |
637bd2e
to
5ae0b13
Compare
5ae0b13
to
cc8730b
Compare
cc8730b
to
cc15bff
Compare
cc15bff
to
f6ca8a3
Compare
While splitting the "old public webdav" and "new public webdav" I came accross a test tagged with It turns out that this bit still doesn't work. I've now marked it as @individual-it FYI |
I ran the unskipped tests marked with issue 49 against the matching Reva PR that solves those: cs3org/reva#877
and they all pass:
please note that some are still skipped due to other issues, see OP for a listing of related issues to address separately. |
we might want to wait for the Reva PRs to be merged and updated in ocis-reva just to be on the safe side |
| uid_file_owner | Alice | | ||
| uid_owner | Alice | | ||
| name | | | ||
When the public downloads the last public shared file with range "bytes=0-9" using the old public WebDAV API |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When the public downloads the last public shared file with range "bytes=0-9" using the old public WebDAV API | |
When the public downloads the last public shared file with range "bytes=0-9" using the new public WebDAV API |
| uid_file_owner | Alice | | ||
| uid_owner | Alice | | ||
| name | | | ||
When the public downloads the last public shared file with range "bytes=0-9" using the old public WebDAV API | ||
Then the downloaded content should be "Random dat" | ||
And the public upload to the last publicly shared file using the old public WebDAV API should fail with HTTP status code "403" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And the public upload to the last publicly shared file using the old public WebDAV API should fail with HTTP status code "403" | |
And the public upload to the last publicly shared file using the new public WebDAV API should fail with HTTP status code "403" |
Then the downloaded content should be "Random dat" | ||
And the public upload to the last publicly shared file using the old public WebDAV API should fail with HTTP status code "403" | ||
And the public upload to the last publicly shared file using the new public WebDAV API should fail with HTTP status code "403" | ||
Then the downloaded content should be "Random dat" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove this line, that check is done above and fail here because there is no download before this step
f6ca8a3
to
421959d
Compare
@individual-it thanks for spotting. I already rechecked those bits over and over again for discrepancies but still managed to miss it. I've fixed that location and squashed. |
Enabled some tests and tagged others that are not working yet. In some feature files, the "old" and "new" public webdav API tests were split into separate scenarios, as OCIS doesn't support the old public webdav API.
421959d
to
9d143b4
Compare
API tests passed in https://cloud.drone.io/owncloud/ocis-reva/521, merging |
Enabled some tests and tagged others that are not working yet.
For owncloud/ocis-reva#49.
A lot blocked by owncloud/ocis-reva#282
REQUIRES: Public Links Download / Upload cs3org/reva#822 for some tests to work.REQUIRES: use gateway to resolve public share info cs3org/reva#872 for some tests to work.Still need to investigate some of the tests tagged with "issue-ocis-reva-49" where the download returns an empty string.Raised and tagged issues:
rename and delete not implemented in public links: Rename or delete file in public link share not implemented ocis-reva#293resolved in the PRTODOs:
@issue-ocis-reva-49
are failing with empty downloads in apiSharePublicLink1/createPublicLinkShare.feature