Api Tests for Links

[exalate-issue-sync]

Tests were enabled as part of owncloud/core#37552

Done

• Single file share: Public link single file share ocis-reva#278
• share_with field must contain special value for public links that have a password: Public link response share_with special value when password set ocis-reva#294
• OCS API expiration date should allow dates without time component: OCS expiration date should accept date without time component ocis-reva#288

Needs test triage

• split old and new endpoint tests: Split old public API webdav tests from new public webdav tests ocis-reva#282
• sort out more tests to enable in Cannot get information of a specific share by providing share_id ocis-reva#249
• refine test tags: Edit public link OCS response ocis-reva#252

Bugfixing

• URL field in response is truncated: Public share URL truncated in response ocis-reva#336 => will unblock many tests
  • fix this
  • enable tests for Edit public link OCS response ocis-reva#252

Bugfixing minor/later

• Webdav PUT response must always be 201 for upload-only shares: https://github.com/owncloud/ocis-reva/issues/286
• prevent sharing root folder: https://github.com/owncloud/ocis-reva/issues/283
• 500 error instead of 404 when accessing non-existing link: https://github.com/owncloud/ocis-reva/issues/290

Implementation missing

• public link permission handling: https://github.com/owncloud/ocis-reva/issues/292

more issues found during enabling:

Deferred

• moving a resource doesn't keep the shares attached (OC storage only, EOS works): owncloud/ocis-reva#335

[exalate-issue-sync]

Remote key is https://jira.owncloud.com/browse/OCIS-104

[exalate-issue-sync]

Remote key is https://jira.owncloud.com/browse/OCIS-104

[exalate-issue-sync]

Remote key is https://jira.owncloud.com/browse/OCIS-104

[exalate-issue-sync]

Remote key is https://jira.owncloud.com/browse/OCIS-104

[PVince81]

Tests were enabled as part of owncloud/core#37552

But some could not due to further issues:

• Single file share: Public link single file share ocis-reva#278
• Webdav PUT response must always be 201 for upload-only shares: https://github.com/owncloud/ocis-reva/issues/286
• public link permission handling: https://github.com/owncloud/ocis-reva/issues/292
• prevent sharing root folder: https://github.com/owncloud/ocis-reva/issues/283
• split old and new endpoint tests: Split old public API webdav tests from new public webdav tests ocis-reva#282
• OCS API expiration date should allow dates without time component: OCS expiration date should accept date without time component ocis-reva#288
• 500 error instead of 404 when accessing non-existing link: https://github.com/owncloud/ocis-reva/issues/290
• share_with field must contain special value for public links that have a password: Public link response share_with special value when password set ocis-reva#294

[PVince81]

PR for enabling more tests owncloud/core#37633

[PVince81]

more issues found during enabling:

• moving a resource doesn't keep the shares attached (OC storage only, EOS works): owncloud/ocis-reva#335
• URL field in response is truncated: Public share URL truncated in response ocis-reva#336
• enable tests for Edit public link OCS response ocis-reva#252 after solving Public share URL truncated in response ocis-reva#336
• sort out more tests to enable in Cannot get information of a specific share by providing share_id ocis-reva#249

[PVince81]

• enable tests from [Tests-Only] enable more public link share tests for get share and edit share core#37633 in reva + ocis-reva drone: Update reva 20200703 ocis-reva#341

[micbar]

follow up @PVince81 and @individual-it to split the ticket.

[PVince81]

I've updated the top post.

The tickets to triage/sort out are under "needs triage".

Regarding bug fixing, I think we should address the URL in response bug as it's blocking many useful tests.

The other bug fixes can be deferred to later.

[PVince81]

Closing in favor of the tickets listed above