use gateway to resolve public share info

[butonic]

alternative approach to #822

[PVince81]

To retest:

• upload with folder share 🚫 fix in Implement/fix more public file operations butonic/reva#5
• download with folder share
• download with single file share => 🚫 FAIL as the Webdav folder appears empty
• rerun API tests locally: [Tests-only] Adjust public link tests for download, upload and other operations owncloud/core#37552

[PVince81]

• TODO: cleanup potential dead code / stuff that is not needed any more => Implement/fix more public file operations butonic/reva#5

• TODO: fix upload code => Implement/fix more public file operations butonic/reva#5

  • properly include the base in URL
  • use unwrap() like for download, get rid of "uploadFullPath"

• TODO: close ocis-reva and ocis PRs as they are not needed any more (we don't need a public link data provider)

• TODO: check review comments from Public Links Download / Upload #822 => all obsolete here and in Implement/fix more public file operations butonic/reva#5

• TODO: fix single file share propfind response, see Public link single file share owncloud/ocis-reva#278 (comment) for reference I had a a missing changeset locally

• TODO: fix single file share operations in public storage provider

• TODO: make linter happy

• TODO: find ways to simply the propfind code

  • separate public code path
  • see if there's a way to get the file name without extra requests

@refs FYI

[PVince81]

• set Expose: false, but need investigation on Point /data to reva frontend owncloud/ocis-proxy#45 as it didn't work when we tested

[PVince81]

PR here to fix upload and implement some more operations: butonic#5

still need to look at single file share which is currently broken here

[PVince81]

cool, so all tests I've enabled pass except the ones for single file share, which is the last thing that needs fixing:

    /srv/www/htdocs/owncloud/tests/acceptance/features/apiSharePublicLink1/createPublicLinkShare.feature:643
    /srv/www/htdocs/owncloud/tests/acceptance/features/apiSharePublicLink1/createPublicLinkShare.feature:644

[PVince81]

Further work here for the linter and code reuse: butonic#6

[PVince81]

Regarding single file share:

@butonic and I had a long session and found out that:

• we agreed that it is not a good idea to add the virtual folder on the CS3 layer, so we need to do it on the Webdav layer. The current approach is a mix of both.
• to do public file share in proper way we need to separate the logic for the virtual folder. We started something here: Attempt public file share butonic/reva#7

Since I'd like to have something merged, we'll split the topics, so here are the next steps:

• finalize public upload/download for folders shares:
  • clean up this PR (use gateway to resolve public share info #872) and remove all extra coded that was added for single file share as it's broken and likely obsolete with the new solution => raised as separate PR Implementation of file operations in public folder shares #877
  • commit the existing API tests
  • get it merged and released
• in parallel: continue here to further explore the solution for single file shares: Attempt public file share butonic/reva#7

[PVince81]

@butonic I've submitted the features that already work in a separate PR #877 so that we can merge those first.

we can keep your branch here "refactor-public-links-download" to continue exploring the single file share implementation.

[PVince81]

please rebase. or should we start a brand new pr for file shares?

[butonic]

obsoleted by #877