-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tiles without extension #5
base: master
Are you sure you want to change the base?
Conversation
The mapprojection package stores tiles without extension. This change allow to use these tiles in the ipgp gui's.
Any help @jmsaurel ? |
Sorry Fred, I somewhat completely forgot your pull request...... Could you please add some words in the log and the recipe to use the mapprojection package in the rst files ? https://github.com/ovsm-dev/ipgp-addons/blob/master/apps/gui/scwev/descriptions/scwev.rst#map |
Done, or close to be: Mapprojection is a commercial closed-source package, are you sure we should document this here? |
Thanks.
I didn't know about this software. |
As you like, could you suggest a reference @gempa-jabe ? |
Actually you are talking about supporting tile images without a file extension. Why does the mapprojection package matter? The mapprojection package does not enforce a tile store. It can use an mbtile database which is a single database file or the standard map files from SC3 in a directory. I don't know right now what you are referring to exactly. Where are files without extension being used by default? |
@gempa-jabe , @FMassin introduced the support of tiles without extensions because, as far as I understood, tiles created with Mappproject doesn't produce images with extensions. Because at the time we developped the ipgp-addons package the SC3 mapping library was not available, we used an OSM library. |
I think @FMassin referes to the gempa mapprojection plugin for SeisComP3 which provides additional map projections. Actually that plugin does not enforce the storage of tiles in any way. There are other plugins which can read tiles from other sources such as mbtiles. So I still don't see the connection of our mapprojection package and the introduced feature. @FMassin can you comment on what exactly you mean with "The mapprojection package stores tiles without extension."? |
I thought would be trivial, but I did a poor job explaning the PR, sorry. Thanks for helping @jmsaurel and @gempa-jabe. I use the mapprojection plugin for having OSM background maps, it stores the tiles locally so it is not downloaded each time. Some map servers don't support jpg, some don't support png. I usually request without specifying the extension. In the end, a local OSM archive is built while using the seiscomp3 mapping apps, and the tiles don't have an extension. I want to use the same archive in the IPGP gui. So I need the IPGP to support files without extension... The proposed code seems to allow it. |
Ah, so your are using the osm tilestore from the mbtiles plugin, not mapprojections ;) @jmsaurel, this plugin does not create tiles itself, it just downloads tiles from any OSM tileserver and stores them locally. Since the tileservers do not require a file extension in their URL, the plugin just stores the file without extension. And @FMassin just wants to use these locally cached tiles in your applications. So that would be similar if you run a download script for any OSM tileserver and store the tiles locally. |
Damn, right I always forget these two are not the same thing! |
The mapprojection package stores tiles without extension. This change allow to use these tiles in the ipgp gui's.