Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tiles without extension #5

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

FMassin
Copy link

@FMassin FMassin commented Oct 26, 2017

The mapprojection package stores tiles without extension. This change allow to use these tiles in the ipgp gui's.

The mapprojection package stores tiles without extension. This change allow to use these tiles in the ipgp gui's.
@FMassin
Copy link
Author

FMassin commented Mar 7, 2018

Any help @jmsaurel ?

@jmsaurel
Copy link
Contributor

jmsaurel commented Nov 7, 2019

Sorry Fred, I somewhat completely forgot your pull request......

Could you please add some words in the log and the recipe to use the mapprojection package in the rst files ?

https://github.com/ovsm-dev/ipgp-addons/blob/master/apps/gui/scwev/descriptions/scwev.rst#map
https://github.com/ovsm-dev/ipgp-addons/blob/master/apps/gui/scaemv/descriptions/scaemv.rst#map

@FMassin
Copy link
Author

FMassin commented Nov 12, 2019

Done, or close to be: Mapprojection is a commercial closed-source package, are you sure we should document this here?

@jmsaurel
Copy link
Contributor

Done, or close to be:

Thanks.

Mapprojection is a commercial closed-source package, are you sure we should document this here?

I didn't know about this software.
Maybe just add the link to the software website, at least in the Changelog ?

@FMassin
Copy link
Author

FMassin commented Nov 12, 2019

As you like, could you suggest a reference @gempa-jabe ?

@gempa-jabe
Copy link
Contributor

Actually you are talking about supporting tile images without a file extension. Why does the mapprojection package matter?

The mapprojection package does not enforce a tile store. It can use an mbtile database which is a single database file or the standard map files from SC3 in a directory. I don't know right now what you are referring to exactly. Where are files without extension being used by default?

@jmsaurel
Copy link
Contributor

@gempa-jabe , @FMassin introduced the support of tiles without extensions because, as far as I understood, tiles created with Mappproject doesn't produce images with extensions.
I have no problems to integrate such modification in ipgp-addons.

Because at the time we developped the ipgp-addons package the SC3 mapping library was not available, we used an OSM library.
We receive regularly questions about how to produce OpenStreetMap tiles, that's why I suggested to @FMassin to include at least one reference about mapprojection somewhere in the documentation.

@gempa-jabe
Copy link
Contributor

I think @FMassin referes to the gempa mapprojection plugin for SeisComP3 which provides additional map projections. Actually that plugin does not enforce the storage of tiles in any way. There are other plugins which can read tiles from other sources such as mbtiles. So I still don't see the connection of our mapprojection package and the introduced feature. @FMassin can you comment on what exactly you mean with "The mapprojection package stores tiles without extension."?

@FMassin
Copy link
Author

FMassin commented Nov 13, 2019

I thought would be trivial, but I did a poor job explaning the PR, sorry. Thanks for helping @jmsaurel and @gempa-jabe. I use the mapprojection plugin for having OSM background maps, it stores the tiles locally so it is not downloaded each time. Some map servers don't support jpg, some don't support png. I usually request without specifying the extension. In the end, a local OSM archive is built while using the seiscomp3 mapping apps, and the tiles don't have an extension. I want to use the same archive in the IPGP gui. So I need the IPGP to support files without extension... The proposed code seems to allow it.

@gempa-jabe
Copy link
Contributor

Ah, so your are using the osm tilestore from the mbtiles plugin, not mapprojections ;)

@jmsaurel, this plugin does not create tiles itself, it just downloads tiles from any OSM tileserver and stores them locally. Since the tileservers do not require a file extension in their URL, the plugin just stores the file without extension. And @FMassin just wants to use these locally cached tiles in your applications. So that would be similar if you run a download script for any OSM tileserver and store the tiles locally.

@FMassin
Copy link
Author

FMassin commented Nov 13, 2019

Damn, right I always forget these two are not the same thing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants