Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(orb-ui): few changes to dataset modal #1098

Merged
merged 1 commit into from
Apr 21, 2022

Conversation

gpazuch
Copy link
Contributor

@gpazuch gpazuch commented Apr 21, 2022

  • name field should be last in form

  • policy selector should not appear when creating dataset from policy view.

  • group selector should not appear when creating dataset from agent group view(does not exist as of yet)

* name field should be last in form

* policy selector should not appear when creating dataset from policy view.

* group selector should not appear when creating dataset from agent group view(does not exist as of yet)
@gpazuch gpazuch added enhancement New feature or request orb-ui Anything related to the angular UI labels Apr 21, 2022
@gpazuch gpazuch requested review from weyrick and lpegoraro April 21, 2022 20:30
@gpazuch gpazuch self-assigned this Apr 21, 2022
Copy link
Contributor

@lpegoraro lpegoraro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lpegoraro lpegoraro merged commit 70a738e into develop Apr 21, 2022
@lpegoraro lpegoraro deleted the feat/dataset-handler-changes branch April 21, 2022 21:40
lpegoraro added a commit that referenced this pull request Apr 25, 2022
* Revert "fix(dataset): add service to remove policy from dataset when it gets invalid because of a policy deletion (#1063)" (#1074)

This reverts commit 4edd705.

Co-authored-by: mclcavalcante <“mariana.cavalcante@encora.com”>

* FIX release generation (#1082)

* feat(orb-ui): #990 #991 UI dataset from policy view (#1069)

* agent policy view improvements
  *  policy groups view
  *  policy dataset view
* dataset modal for add | edit | delete | create-from<policy|group|sink> operations

* feat(orb-ui): Remove Dataset menu item (#1097)

* remove dataset menu item

Datasat now acessible via Agent Policy View only.

* feat(orb-ui): few changes to dataset modal (#1098)

* name field should be last in form

* policy selector should not appear when creating dataset from policy view.

* group selector should not appear when creating dataset from agent group view(does not exist as of yet)

* [FIX] new release version (#1101)

* wip (#1030)

Co-authored-by: mclcavalcante <mcavalcante@daitan.com>
Co-authored-by: mclcavalcante <“mariana.cavalcante@encora.com”>
Co-authored-by: etaques <97463920+etaques@users.noreply.github.com>
Co-authored-by: Guilhermo Pazuch <1490938+gpazuch@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request orb-ui Anything related to the angular UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants