Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Dataset creation from policy view page #990

Closed
iatdaitan opened this issue Mar 25, 2022 · 2 comments
Closed

Enable Dataset creation from policy view page #990

iatdaitan opened this issue Mar 25, 2022 · 2 comments
Assignees
Labels
orb-ui Anything related to the angular UI p2 An issue that needs to be addressed on a reasonable timescale

Comments

@iatdaitan
Copy link
Contributor

iatdaitan commented Mar 25, 2022

As a User, I would like to be able to create a dataset from the Policy View Page so it will make it easier to direct associate it with a specific policy.

--

General Figma Frame: https://www.figma.com/file/5jZNpc8JMsY2Tj3OQJzgxt/Orb-Product-Portal-UI?node-id=2415%3A14590

Screenshot:

  • List view with new dataset button
    image

  • Modal after the new dataset button is clicked (Note: the modal is meant for editing a dataset, if it gets confuse, please get in touch with Erica to provide a new design for creating a dataset only.)
    image

FR001: The Dataset List View inside of the Policy view page should have a New Dataset button to allow the user to click
FR002: Upon click, a modal should be shown to the user allowing a new dataset to be created.
FR003: The policy field should be disabled and show the current and visible policy.

@gpazuch gpazuch self-assigned this Mar 30, 2022
@gpazuch gpazuch added the orb-ui Anything related to the angular UI label Mar 30, 2022
@gpazuch gpazuch added the p2 An issue that needs to be addressed on a reasonable timescale label Apr 11, 2022
gpazuch added a commit that referenced this issue Apr 21, 2022
* agent policy view improvements
  *  policy groups view
  *  policy dataset view
* dataset modal for add | edit | delete | create-from<policy|group|sink> operations
@manrodrigues
Copy link
Contributor

@gpazuch
1 - policies' view page is crashed when the group or the sink list is expanded/selected.. the same occurs on dataset editing:

page_bug

page_details_bug

2- only the "name" filter are working for datasets

3- Once that a sink is added, is not possible to remove

unable_remove_sink

4 - user is allowed to add multiple times the same sink to the dataset:

image

5 - the modal for create a dataset must not be named as "dataset details", once this is for editing modal:

image

6 - dataset details (after click over the name of an existing dataset) has a "g" above "sinks":

image

7 - Button "save" is enabled without required fields on creation and editing modal:

image

image

8 - page is not refreshed after create, editing or delete a dataset

9 - mouse icon must be a hand icon when over the dataset name, once it is clickable

10 - of course this is just a minor, but for maintain the pattern, the name of the button for create a dataset must be

"+ new dataset", not "+ create dataset"

image

And, one question, why we have the amount of datasets displayed into brackets? we don't have this for any other section on orb.

image

@manrodrigues
Copy link
Contributor

1 - #1108
2 - #1109
3 - #1110
4 - #1111
5 - #1112
6 - #1113
7 - #1114
8 - #1115
9 - #1116
10 - #1117

Extra - #1118

lpegoraro added a commit that referenced this issue Apr 25, 2022
* Revert "fix(dataset): add service to remove policy from dataset when it gets invalid because of a policy deletion (#1063)" (#1074)

This reverts commit 4edd705.

Co-authored-by: mclcavalcante <“mariana.cavalcante@encora.com”>

* FIX release generation (#1082)

* feat(orb-ui): #990 #991 UI dataset from policy view (#1069)

* agent policy view improvements
  *  policy groups view
  *  policy dataset view
* dataset modal for add | edit | delete | create-from<policy|group|sink> operations

* feat(orb-ui): Remove Dataset menu item (#1097)

* remove dataset menu item

Datasat now acessible via Agent Policy View only.

* feat(orb-ui): few changes to dataset modal (#1098)

* name field should be last in form

* policy selector should not appear when creating dataset from policy view.

* group selector should not appear when creating dataset from agent group view(does not exist as of yet)

* [FIX] new release version (#1101)

* wip (#1030)

Co-authored-by: mclcavalcante <mcavalcante@daitan.com>
Co-authored-by: mclcavalcante <“mariana.cavalcante@encora.com”>
Co-authored-by: etaques <97463920+etaques@users.noreply.github.com>
Co-authored-by: Guilhermo Pazuch <1490938+gpazuch@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
orb-ui Anything related to the angular UI p2 An issue that needs to be addressed on a reasonable timescale
Projects
None yet
Development

No branches or pull requests

3 participants