Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(orb-ui): few changes to dataset modal #1098

Merged
merged 1 commit into from
Apr 21, 2022
Merged

feat(orb-ui): few changes to dataset modal #1098

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 19 additions & 19 deletions ui/src/app/pages/datasets/dataset-from/dataset-from.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,22 +11,8 @@
</nb-card-header>
<nb-card-body>
<form [formGroup]="form">
<!-- NAME-->
<nb-form-field>
<div>
<label class="font-weight-bold">Dataset Name</label>
<span class="required">*</span>
</div>
<input autofocus
data-orb-qa-id="name"
fieldSize="medium"
formControlName="name"
fullWidth="true"
nbInput/>
</nb-form-field>
<br>
<!-- GROUP-->
<nb-form-field>
<nb-form-field [hidden]="!!group">
<div>
<label class="font-weight-bold">Agent Group</label>
<span class="required">*</span>
Expand All @@ -45,10 +31,10 @@
[attr.data-orb-qa-id]="'available_agent_group: '+agentGroup.id" [id]="agentGroup.id"
[value]="agentGroup.id">{{ agentGroup.name }}</nb-option>
</nb-select>
<br>
</nb-form-field>
<br>
<!-- POLICY-->
<nb-form-field>
<nb-form-field [hidden]="policy">
<div>
<label class="font-weight-bold">Collection Policy</label>
<span class="required">*</span>
Expand All @@ -67,16 +53,30 @@
[attr.data-orb-qa-id]="'available_agent_policy: '+agentPolicy.id" [id]="agentPolicy.id"
[value]="agentPolicy.id">{{ agentPolicy.name }}</nb-option>
</nb-select>
<br>g
</nb-form-field>
<br>
<!-- SINK-->
<div>
<label class="font-weight-bold">Sinks</label>
<span class="required">*</span>
</div>
<ngx-sink-display [(sinks)]="selectedSinks"></ngx-sink-display>
<ngx-sink-control [(selectedSinks)]="selectedSinks" [availableSinks]="availableSinks"></ngx-sink-control>

<br>
<!-- NAME-->
<br>
<nb-form-field>
<div>
<label class="font-weight-bold">Dataset Name</label>
<span class="required">*</span>
</div>
<input autofocus
data-orb-qa-id="name"
fieldSize="medium"
formControlName="name"
fullWidth="true"
nbInput/>
</nb-form-field>
</form>
</nb-card-body>
<nb-card-footer>
Expand Down
1 change: 0 additions & 1 deletion ui/src/app/shared/components/orb/policy/policy-datasets/policy-datasets.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,6 @@ export class PolicyDatasetsComponent implements OnInit, OnDestroy, AfterViewInit
closeOnEsc: true,
context: {
dataset,
policy: this.policy,
},
}).onClose.subscribe(resp => {
if (resp === 'changed' || 'deleted') {
Expand Down