Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Python 3.11 #164

Closed
29 of 30 tasks
nzw0301 opened this issue Jan 14, 2023 · 16 comments
Closed
29 of 30 tasks

Support Python 3.11 #164

nzw0301 opened this issue Jan 14, 2023 · 16 comments
Labels
contribution-welcome Issue that welcomes contribution. feature Change that does not break compatibility, but affects the public interfaces of examples. good first issue Good first issue for contribution. stale Exempt from stale bot labeling.

Comments

@nzw0301
Copy link
Member

nzw0301 commented Jan 14, 2023

Motivation

Sub-task of optuna/optuna#3964 for tracking this repo.

Description

Add python 3.11 to github action's version matrix. An example PR is #160.

Alternatives (optional)

Additional context (optional)

I summarise the status of targets as follows:

@nzw0301 nzw0301 added the feature Change that does not break compatibility, but affects the public interfaces of examples. label Jan 14, 2023
@Kaushik-Iyer
Copy link

Are all of them done?

@nzw0301
Copy link
Member Author

nzw0301 commented Jan 19, 2023

@Kaushik-Iyer As in the issue description, we need to wait for third party libraries' python 3.11 support.

@github-actions
Copy link

This issue has not seen any recent activity.

@github-actions github-actions bot added the stale Exempt from stale bot labeling. label Feb 14, 2023
@nzw0301 nzw0301 removed the stale Exempt from stale bot labeling. label Feb 15, 2023
@github-actions
Copy link

This issue has not seen any recent activity.

@github-actions github-actions bot added the stale Exempt from stale bot labeling. label Mar 26, 2023
@github-actions github-actions bot removed the stale Exempt from stale bot labeling. label Apr 3, 2023
@hvy
Copy link
Member

hvy commented Apr 10, 2023

tensorflow now supports 3.11, see optuna/optuna#3964 (comment)

All examples blocked by tensorflow might be worth revisiting. While I haven't checked for possible errors, please let me mark this issue as contribution welcome for others to try picking it up. Please let me know if there are uncertainties.

@hvy hvy added the contribution-welcome Issue that welcomes contribution. label Apr 10, 2023
@github-actions
Copy link

github-actions bot commented May 2, 2023

This issue has not seen any recent activity.

@github-actions github-actions bot added the stale Exempt from stale bot labeling. label May 2, 2023
@nzw0301 nzw0301 removed the stale Exempt from stale bot labeling. label May 5, 2023
@github-actions
Copy link

This issue has not seen any recent activity.

@github-actions github-actions bot added the stale Exempt from stale bot labeling. label May 21, 2023
@Alnusjaponica
Copy link
Collaborator

It seems Python 3.11 is now supported by tensorflow. See tensorflow/tensorflow#58032 for more detail.

@Alnusjaponica
Copy link
Collaborator

Same as PyTorch(pytorch/pytorch#86566) and Numba (numba/numba#8304)

@github-actions github-actions bot removed the stale Exempt from stale bot labeling. label Jul 17, 2023
@github-actions
Copy link

This issue has not seen any recent activity.

@github-actions github-actions bot added the stale Exempt from stale bot labeling. label Jul 31, 2023
@Alnusjaponica
Copy link
Collaborator

Alnusjaponica commented Oct 12, 2023

It seems the development of MXNet has stopped before the release of python 3.11 and the test does not pass.
Therefore, it will be enough to close this issue after #214 is merged.

@github-actions github-actions bot removed the stale Exempt from stale bot labeling. label Oct 12, 2023
@Alnusjaponica
Copy link
Collaborator

It is possible to run MXNet tests in Python 3.11, but it is necessary to install Numpy<1.24.0. To add to the Python 3.11 job to MXNet CI, reversing the order of the dependency list in mxnet/requirements.txt suffices. This is because Numpy>=1.24.0 is actually installed before running pip install -r requirements.txt in the CI, and it is necessary to reinstall Numpy<1.24.0 before the CI installs MXNet. For more details, please refer to Alnusjaponica#1.

@Alnusjaponica Alnusjaponica added the good first issue Good first issue for contribution. label Oct 26, 2023
Copy link

github-actions bot commented Nov 9, 2023

This issue has not seen any recent activity.

@github-actions github-actions bot added the stale Exempt from stale bot labeling. label Nov 9, 2023
@nzw0301
Copy link
Member Author

nzw0301 commented Nov 20, 2023

FYI: MXNet has been archived since 18 Nov. 2023, so the incompatibility with numpy will not be addressed anymore on the MXNet side.

@github-actions github-actions bot removed the stale Exempt from stale bot labeling. label Nov 20, 2023
Copy link

github-actions bot commented Dec 4, 2023

This issue has not seen any recent activity.

@github-actions github-actions bot added the stale Exempt from stale bot labeling. label Dec 4, 2023
@not522
Copy link
Member

not522 commented Dec 5, 2023

All except MXNet have been supported, and MXNet has finished development. Therefore, Python 3.11 support is considered complete. Thank you for your contributions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution-welcome Issue that welcomes contribution. feature Change that does not break compatibility, but affects the public interfaces of examples. good first issue Good first issue for contribution. stale Exempt from stale bot labeling.
Projects
None yet
Development

No branches or pull requests

5 participants