Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3.11 wheels #6517

Closed
EpicWink opened this issue Sep 13, 2022 · 23 comments
Closed

Python 3.11 wheels #6517

EpicWink opened this issue Sep 13, 2022 · 23 comments
Labels
⬆️ Upstream Involves an upstream project 🔍 Monitor Depends on an external condition(s); monitor it 🤖 type: Infrastructure CI, packaging, tools and automation
Milestone

Comments

@EpicWink
Copy link

EpicWink commented Sep 13, 2022

Build wheels for Python 3.11

Should be just adding cibw_python: "cp311-*" to the build-wheels CI job matrix

Note you'll likely be waiting for the Python 3.11 wheels for:

@skshetry
Copy link

You can add cp311-cp311 to the python-versions, that PR only changes the default. However, you may need to update the version of RalfG/python-wheels-manylinux-build to the latest.
See dulwich/pythonwheels.yml for an example.

@lagru lagru added 🔍 Monitor Depends on an external condition(s); monitor it 🤖 type: Infrastructure CI, packaging, tools and automation ⬆️ Upstream Involves an upstream project labels Sep 13, 2022
@grlee77
Copy link
Contributor

grlee77 commented Sep 14, 2022

Thanks, I was planning to open a PR soon, porting the same changes I did for PyWavelets here. Aside from the small .yaml file updates, we have to update the NumPy version pinnings in our pyproject.toml to be consistent with current Values in SciPy/PyWavelets (where they were recently updated to account for Python 3.11).

I will tag the new PyWavelets release tonight or tomorrow.

For SciPy we definitely won't want it to build from source, but it looks like we can start testing from the nightly 3.11 wheels here.

@lagru
Copy link
Member

lagru commented Sep 20, 2022

See #6519 for progress on this.

@papr
Copy link

papr commented Oct 11, 2022

Scipy has released 3.11 wheels in their latest release.

@stefanv
Copy link
Member

stefanv commented Oct 11, 2022

In progress: #6566
After this, we'll enable wheels.

@stefanv stefanv closed this as completed Oct 11, 2022
@lagru
Copy link
Member

lagru commented Oct 16, 2022

Reopening so that we have an issue tracking this request. See #6581 for the second step of the progress.

@Erotemic
Copy link
Contributor

Erotemic commented Nov 9, 2022

FYI: imread just released their 311 wheels, so the last blocker in the original post is gone.

@Erotemic
Copy link
Contributor

Erotemic commented Dec 3, 2022

Any updates on this? It seems like all that's left to do is make the release.

@stefanv
Copy link
Member

stefanv commented Dec 3, 2022

Yes, @grlee77 will be working on fixing broken Windows wheels this week.

@sebwr
Copy link

sebwr commented Dec 3, 2022

Is there also an estimate for linux?
As I tried it at the beginning of November it looked like the wheels were also broken on linux.

@grlee77
Copy link
Contributor

grlee77 commented Dec 3, 2022

I pushed an update that fixed the AMD64 Windows wheels and dropped 32-bit Windows support. The linux ones were already working aside from a couple of 32-bit ones (also dropped in that PR). See this comment and link therein:
#6581 (comment)

edit: just remembered that all wheels were initially failing due to failure to import lazy_loader at test time, but that is also now resolved in the PR linked above

@lagru
Copy link
Member

lagru commented Dec 21, 2022

Can we close this now that #6581 is merged? Or should we wait until we've actually released 3.11 wheels?

@sebwr
Copy link

sebwr commented Dec 21, 2022

Is there an estimate, when the 3.11 wheels are released?

@lagru
Copy link
Member

lagru commented Dec 21, 2022

We have been meaning to release version 0.20 a few weeks ago but it got stalled. I'm not expecting much to happen before the new year but hope that we will push a pre-release candidate soon after that. @sebwr, sorry for the wait.

@sebwr
Copy link

sebwr commented Dec 21, 2022

No hurries, Im also done for this year. Happy holidays for everyone involved.

@sebwr
Copy link

sebwr commented Jan 9, 2023

Any news to the v0.20 update including the 3.11 wheels?

@lagru
Copy link
Member

lagru commented Jan 14, 2023

Hey @sebwr, we are working on a release candidate 0.20.0rc1 right now. It's currently blocked by #6667 but after that is resolved, the proper release shouldn't be far away.

@sebwr
Copy link

sebwr commented Jan 27, 2023

Are there infos for the release date?

@pllim
Copy link

pllim commented Feb 15, 2023

This appears to be an issue still. I am unable to install scikit-image in Python 3.11 on Windows.

pip install scikit-image --pre works but that also requires me to install it separately, so pip install some_downstream_package that requires scikit-image in Python 3.11 will fail.

@stefanv
Copy link
Member

stefanv commented Feb 16, 2023

The wheels are building just fine, the pre-releases are out on PyPi, and the main release itself will be available in a week.

@pllim If --pre works, then there's nothing else to be done right now.

@pllim
Copy link

pllim commented Feb 16, 2023

@stefanv , correct, the pre-release installs fine. I see that RCs are actively being pushed. Good luck in the release!

@jarrodmillman jarrodmillman added this to the 0.20 milestone Feb 20, 2023
@jarrodmillman
Copy link
Contributor

See https://pypi.org/project/scikit-image/0.20.0rc8/#files

@stefanv
Copy link
Member

stefanv commented Feb 22, 2023

We're about to publish the next release, so I'm going to close this to clear the milestone. Thanks for your feedback, all.

@stefanv stefanv closed this as completed Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⬆️ Upstream Involves an upstream project 🔍 Monitor Depends on an external condition(s); monitor it 🤖 type: Infrastructure CI, packaging, tools and automation
Projects
None yet
Development

No branches or pull requests

10 participants