Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add python 3.11 to ray's version matrix #174

Merged
merged 1 commit into from
Mar 10, 2023

Conversation

nzw0301
Copy link
Member

@nzw0301 nzw0301 commented Feb 27, 2023

Motivation

Resolve a sub-task of #164.

Description of the changes

As is the PR title.

@nzw0301 nzw0301 mentioned this pull request Feb 27, 2023
30 tasks
@toshihikoyanase
Copy link
Member

Thank you for your PR. The CI passed, but the pypi of ray does not list Python 3.11.
Do you check the example on Python 3.11?

image

@nzw0301
Copy link
Member Author

nzw0301 commented Feb 28, 2023

No, I didn't check it. In fact, the latest stable ray supports Python 3.11 experimentally, so I'm not sure the example works without any errors...

@nzw0301
Copy link
Member Author

nzw0301 commented Feb 28, 2023

I might take time to prepare for creating a python 3.11 environment for the local test, but I'll take a look at it.

@nzw0301
Copy link
Member Author

nzw0301 commented Feb 28, 2023

Unfortunately, ray doesn't support macOS with python 3.11 yet, so I cannot test the example soon...

Ref: https://docs.ray.io/en/latest/ray-overview/installation.html

@toshihikoyanase toshihikoyanase self-assigned this Mar 2, 2023
@toshihikoyanase
Copy link
Member

Thank you for your confirmation. I'll try it on WSL2.

@github-actions
Copy link

github-actions bot commented Mar 9, 2023

This pull request has not seen any recent activity.

@github-actions github-actions bot added the stale Exempt from stale bot labeling. label Mar 9, 2023
@toshihikoyanase
Copy link
Member

Sorry for the delayed response. Let me check this PR today.

Copy link
Member

@toshihikoyanase toshihikoyanase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirmed that joblib/ray_joblib.py worked with Python 3.11 on a Linux machine.
LGTM!

$ cd ray
$ pip install oputna scikit-learn ray
$ python ray_joblib.py
...
Number of finished trials: 100
Elapsed time: 0:05:28.487118
Best trial:
  Value: 0.9866666666666667
  Params:
    classifier: SVC
    svc_c: 4.216210865309544

During the review, I'm wondering the following things:

  • Why the CI workflow does not execute the example. It easily worked like the other examples in my environment.
  • Why requirements.txt lacks in this directory

Maybe we can work on them in follow-up PRs.

@toshihikoyanase toshihikoyanase added this to the v3.2.0 milestone Mar 10, 2023
@toshihikoyanase toshihikoyanase added the CI Continuous integration. label Mar 10, 2023
@toshihikoyanase toshihikoyanase merged commit 07f877e into optuna:main Mar 10, 2023
@nzw0301 nzw0301 deleted the add-python-3.11-ray branch March 10, 2023 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous integration. stale Exempt from stale bot labeling.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants