-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add python 3.11 to ray's version matrix #174
Conversation
Thank you for your PR. The CI passed, but the pypi of ray does not list Python 3.11. |
No, I didn't check it. In fact, the latest stable ray supports Python 3.11 experimentally, so I'm not sure the example works without any errors... |
I might take time to prepare for creating a python 3.11 environment for the local test, but I'll take a look at it. |
Unfortunately, ray doesn't support macOS with python 3.11 yet, so I cannot test the example soon... Ref: https://docs.ray.io/en/latest/ray-overview/installation.html |
Thank you for your confirmation. I'll try it on WSL2. |
This pull request has not seen any recent activity. |
Sorry for the delayed response. Let me check this PR today. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I confirmed that joblib/ray_joblib.py
worked with Python 3.11 on a Linux machine.
LGTM!
$ cd ray
$ pip install oputna scikit-learn ray
$ python ray_joblib.py
...
Number of finished trials: 100
Elapsed time: 0:05:28.487118
Best trial:
Value: 0.9866666666666667
Params:
classifier: SVC
svc_c: 4.216210865309544
During the review, I'm wondering the following things:
- Why the CI workflow does not execute the example. It easily worked like the other examples in my environment.
- Why
requirements.txt
lacks in this directory
Maybe we can work on them in follow-up PRs.
Motivation
Resolve a sub-task of #164.
Description of the changes
As is the PR title.