-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump up python versions #214
Conversation
@not522 Could you review this PR? |
pytorch/requirements.txt
Outdated
torch==2.0.0 | ||
torchvision==0.15.1 | ||
torchaudio==2.0.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about leaving these without version specification? I think that it should work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds reasonable and it might enable the tests run in python 3.7.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Motivation
Resolve optuna/optuna#3964 and #164
Description of the changes
pytorch/requirements.txt
andrl/requirements.txt
, due to the impossibility of installing the same version of the necessary libraries in both Python 3.7 and 3.11.See https://github.com/pytorch/pytorch/releases and https://stable-baselines3.readthedocs.io/en/master/misc/changelog.html for reference.
Please note that the CI job for Python 3.7 has been removed inpytorch
and `rl.