Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump up python versions #214

Merged
merged 12 commits into from
Oct 23, 2023
Merged

Conversation

Alnusjaponica
Copy link
Collaborator

@Alnusjaponica Alnusjaponica commented Oct 12, 2023

Motivation

Resolve optuna/optuna#3964 and #164

Description of the changes

@Alnusjaponica Alnusjaponica marked this pull request as ready for review October 12, 2023 11:38
@Alnusjaponica Alnusjaponica mentioned this pull request Oct 12, 2023
30 tasks
@contramundum53 contramundum53 requested a review from not522 October 16, 2023 08:36
@contramundum53
Copy link
Member

@not522 Could you review this PR?

@contramundum53 contramundum53 removed the request for review from not522 October 16, 2023 08:46
Comment on lines 6 to 8
torch==2.0.0
torchvision==0.15.1
torchaudio==2.0.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about leaving these without version specification? I think that it should work.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds reasonable and it might enable the tests run in python 3.7.

Copy link
Member

@not522 not522 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@not522 not522 merged commit 11edf27 into optuna:main Oct 23, 2023
110 checks passed
@not522 not522 added this to the v3.5.0 milestone Oct 23, 2023
@Alnusjaponica Alnusjaponica deleted the bump-up-python-versions branch October 23, 2023 07:02
@nzw0301 nzw0301 mentioned this pull request Dec 20, 2023
32 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Python 3.11
3 participants