Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1732214: Fix panic when binding already exists #964

Conversation

ecordell
Copy link
Member

This is a manual cherry-pick of #959

@cblecker

openshift-merge-robot and others added 2 commits June 27, 2019 18:21
Bug 1723851: fix(catalog): do not add owner references to clusterroles or crbs (4.1 cherrypick)
@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jul 24, 2019
@openshift-ci-robot
Copy link
Collaborator

@ecordell: This pull request references an invalid Bugzilla bug:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, but it is MODIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1732302: Fix panic when binding already exists

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 24, 2019
@ecordell ecordell changed the title Bug 1732302: Fix panic when binding already exists Bug 1732911: Fix panic when binding already exists Jul 24, 2019
@openshift-ci-robot
Copy link
Collaborator

@ecordell: This pull request references an invalid Bugzilla bug:

  • expected dependent Bugzilla bug to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is MODIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1732911: Fix panic when binding already exists

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ecordell ecordell changed the title Bug 1732911: Fix panic when binding already exists Bug 1732302: Fix panic when binding already exists Jul 24, 2019
@openshift-ci-robot
Copy link
Collaborator

@ecordell: This pull request references an invalid Bugzilla bug:

  • expected the bug to target the "4.1.z" release, but it targets "4.2.0" instead
  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, but it is MODIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1732302: Fix panic when binding already exists

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ecordell
Copy link
Member Author

/bugzilla refresh

@openshift-ci-robot
Copy link
Collaborator

@ecordell: This pull request references an invalid Bugzilla bug:

  • expected the bug to target the "4.1.z" release, but it targets "4.2.0" instead
  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, but it is MODIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ecordell
Copy link
Member Author

/bugzilla refresh

@openshift-ci-robot
Copy link
Collaborator

@ecordell: This pull request references an invalid Bugzilla bug:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, but it is MODIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

pkg/controller/operators/catalog/operator.go Outdated Show resolved Hide resolved
pkg/controller/operators/catalog/operator.go Outdated Show resolved Hide resolved
@ecordell
Copy link
Member Author

/retest

Evan Cordell and others added 2 commits July 24, 2019 17:21
Co-Authored-By: Christoph Blecker <admin@toph.ca>
Co-Authored-By: Christoph Blecker <admin@toph.ca>
@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 24, 2019
@cblecker
Copy link
Contributor

/lgtm

@ecordell I think there was two BZs opened.. the original (https://bugzilla.redhat.com/show_bug.cgi?id=1732214) and the one @jianzhangbjz opened (https://bugzilla.redhat.com/show_bug.cgi?id=1732302). I don't know if that makes a difference in resolving the invalid-bug label

@openshift-ci-robot
Copy link
Collaborator

@cblecker: changing LGTM is restricted to collaborators

In response to this:

/lgtm

@ecordell I think there was two BZs opened.. the original (https://bugzilla.redhat.com/show_bug.cgi?id=1732214) and the one @jianzhangbjz opened (https://bugzilla.redhat.com/show_bug.cgi?id=1732302). I don't know if that makes a difference in resolving the invalid-bug label

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ecordell
Copy link
Member Author

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jul 25, 2019
@openshift-ci-robot
Copy link
Collaborator

@ecordell: This pull request references a valid Bugzilla bug. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jul 25, 2019
Copy link
Member

@njhale njhale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 25, 2019
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, ecordell, njhale

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ecordell ecordell changed the title Bug 1732302: Fix panic when binding already exists Bug 1733324: Fix panic when binding already exists Jul 25, 2019
@openshift-ci-robot openshift-ci-robot removed the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jul 25, 2019
@openshift-ci-robot
Copy link
Collaborator

@ecordell: This pull request references an invalid Bugzilla bug:

  • expected the bug to target the "4.1.z" release, but it targets "4.2.0" instead
  • expected dependent Bugzilla bug to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is MODIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1733324: Fix panic when binding already exists

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jul 25, 2019
@ecordell
Copy link
Member Author

/bugzilla refresh

@openshift-ci-robot
Copy link
Collaborator

@ecordell: This pull request references an invalid Bugzilla bug:

  • expected the bug to target the "4.1.z" release, but it targets "4.2.0" instead
  • expected dependent Bugzilla bug to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is MODIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ecordell
Copy link
Member Author

/bugzilla refresh

@openshift-ci-robot
Copy link
Collaborator

@ecordell: This pull request references an invalid Bugzilla bug:

  • expected dependent Bugzilla bug to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is MODIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eparis
Copy link

eparis commented Jul 25, 2019

@cblecker FYI Evan's got the bugs and PRs all set up perfectly now. We have a bug with target release 4.2 (1732302) which 'blocks' a bug with target release 4.1 (1733324). And now the bot is telling us that 1733324 (4.2) is not yet verified by QE. Once that bug goes VERIFIED we should run /bugzilla refresh again.

Thank you both!

@ecordell ecordell changed the title Bug 1733324: Fix panic when binding already exists Bug 1732214: Fix panic when binding already exists Aug 6, 2019
@openshift-ci-robot
Copy link
Collaborator

@ecordell: This pull request references a valid Bugzilla bug. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Bug 1732214: Fix panic when binding already exists

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Aug 6, 2019
@derekwaynecarr derekwaynecarr added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Aug 12, 2019
@derekwaynecarr
Copy link

/retest

2 similar comments
@ecordell
Copy link
Member Author

/retest

@ecordell
Copy link
Member Author

/retest

@openshift-merge-robot openshift-merge-robot merged commit e782ca5 into operator-framework:release-4.1 Aug 16, 2019
@openshift-ci-robot
Copy link
Collaborator

@ecordell: All pull requests linked via external trackers have merged. The Bugzilla bug has been moved to the MODIFIED state.

In response to this:

Bug 1732214: Fix panic when binding already exists

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants