Bug 1732302: Fix panic when binding already exists

[cblecker]

Fix the following panic when the RoleBinding/ClusterRoleBinding already exists.

Note this will need to be backported, as it exists in the release-4.x branches as well.

panic: assignment to entry in nil map

goroutine 183 [running]:
github.com/operator-framework/operator-lifecycle-manager/pkg/controller/operators/catalog.(*Operator).ExecutePlan(0xc4204bec00, 0xc421924000, 0x1, 0x1)
        /go/src/github.com/operator-framework/operator-lifecycle-manager/pkg/controller/operators/catalog/operator.go:1187 +0x4243

[ecordell]

/lgtm
/retest

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, ecordell

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [ecordell]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ecordell]

/hold

Do we have a BZ for this?

[cblecker]

@ecordell No, I haven't filed one yet. Been debugging this today. I'll get one filed now.

[cblecker]

/retest

[cblecker]

@ecordell Filed BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1732214

Looks like CI is timing out with unrelated errors

[jianzhangbjz]

/retest

[ecordell]

/retest

[openshift-ci-robot]

@cblecker: This pull request references a valid Bugzilla bug. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Bug 1732302: Fix panic when binding already exists

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[ecordell]

/retest
/hold cancel

[ecordell]

/retest

[cblecker]

/retest

[cblecker]

/test e2e-aws-olm

[cblecker]

/retest

[cblecker]

/retest
The timeout really seems unrelated, but I’ve seen some green runs of this job recently so if this fails again there may really be some unintended consequence.

[cblecker]

Okay, it did pass once: https://prow.svc.ci.openshift.org/pr-history/?org=operator-framework&repo=operator-lifecycle-manager&pr=959
Just a flakey e2e test
/test e2e-aws-olm

[cblecker]

/retest

[cblecker]

/retest

[ecordell]

/retest

[cblecker]

/retest

[openshift-ci-robot]

@cblecker: The following test failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
ci/prow/e2e-aws-olm	93c999a	link	/test e2e-aws-olm

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[ecordell]

e2e-aws-olm is failing due to a flake introduced in a recent commit. since we've seen it pass at least once on this PR, merging this manually

[openshift-ci-robot]

@cblecker: All pull requests linked via external trackers have merged. The Bugzilla bug has been moved to the MODIFIED state.

In response to this:

Bug 1732302: Fix panic when binding already exists

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[ecordell]

/cherry-pick release-4.1

[openshift-cherrypick-robot]

@ecordell: #959 failed to apply on top of branch "release-4.1":

error: Failed to merge in the changes.
Using index info to reconstruct a base tree...
A	pkg/controller/operators/catalog/step_ensurer.go
Falling back to patching base and 3-way merge...
CONFLICT (modify/delete): pkg/controller/operators/catalog/step_ensurer.go deleted in HEAD and modified in Fix panic when binding already exists. Version Fix panic when binding already exists of pkg/controller/operators/catalog/step_ensurer.go left in tree.
Patch failed at 0001 Fix panic when binding already exists

In response to this:

/cherry-pick release-4.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.