Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1732302: Fix panic when binding already exists #959

Merged
merged 1 commit into from
Jul 24, 2019

Conversation

cblecker
Copy link
Contributor

Fix the following panic when the RoleBinding/ClusterRoleBinding already exists.

Note this will need to be backported, as it exists in the release-4.x branches as well.

panic: assignment to entry in nil map

goroutine 183 [running]:
github.com/operator-framework/operator-lifecycle-manager/pkg/controller/operators/catalog.(*Operator).ExecutePlan(0xc4204bec00, 0xc421924000, 0x1, 0x1)
        /go/src/github.com/operator-framework/operator-lifecycle-manager/pkg/controller/operators/catalog/operator.go:1187 +0x4243

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 22, 2019
@ecordell
Copy link
Member

/lgtm
/retest

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 22, 2019
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, ecordell

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 22, 2019
@ecordell
Copy link
Member

/hold

Do we have a BZ for this?

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 22, 2019
@cblecker
Copy link
Contributor Author

@ecordell No, I haven't filed one yet. Been debugging this today. I'll get one filed now.

@cblecker
Copy link
Contributor Author

/retest

@cblecker
Copy link
Contributor Author

@ecordell Filed BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1732214

Looks like CI is timing out with unrelated errors

@jianzhangbjz
Copy link
Contributor

/retest

1 similar comment
@ecordell
Copy link
Member

/retest

@ecordell ecordell changed the title Fix panic when binding already exists Bug 1732302: Fix panic when binding already exists Jul 23, 2019
@openshift-ci-robot
Copy link
Collaborator

@cblecker: This pull request references a valid Bugzilla bug. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Bug 1732302: Fix panic when binding already exists

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jul 23, 2019
@ecordell
Copy link
Member

/retest
/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 23, 2019
@ecordell
Copy link
Member

/retest

1 similar comment
@cblecker
Copy link
Contributor Author

/retest

@cblecker
Copy link
Contributor Author

/test e2e-aws-olm

@cblecker
Copy link
Contributor Author

/retest

@cblecker
Copy link
Contributor Author

/retest
The timeout really seems unrelated, but I’ve seen some green runs of this job recently so if this fails again there may really be some unintended consequence.

@cblecker
Copy link
Contributor Author

Okay, it did pass once: https://prow.svc.ci.openshift.org/pr-history/?org=operator-framework&repo=operator-lifecycle-manager&pr=959
Just a flakey e2e test
/test e2e-aws-olm

@cblecker
Copy link
Contributor Author

/retest

1 similar comment
@cblecker
Copy link
Contributor Author

/retest

@ecordell
Copy link
Member

/retest

1 similar comment
@cblecker
Copy link
Contributor Author

/retest

@openshift-ci-robot
Copy link
Collaborator

@cblecker: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-aws-olm 93c999a link /test e2e-aws-olm

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ecordell
Copy link
Member

e2e-aws-olm is failing due to a flake introduced in a recent commit. since we've seen it pass at least once on this PR, merging this manually

@ecordell ecordell merged commit d1be59c into operator-framework:master Jul 24, 2019
@openshift-ci-robot
Copy link
Collaborator

@cblecker: All pull requests linked via external trackers have merged. The Bugzilla bug has been moved to the MODIFIED state.

In response to this:

Bug 1732302: Fix panic when binding already exists

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ecordell
Copy link
Member

/cherry-pick release-4.1

@openshift-cherrypick-robot

@ecordell: #959 failed to apply on top of branch "release-4.1":

error: Failed to merge in the changes.
Using index info to reconstruct a base tree...
A	pkg/controller/operators/catalog/step_ensurer.go
Falling back to patching base and 3-way merge...
CONFLICT (modify/delete): pkg/controller/operators/catalog/step_ensurer.go deleted in HEAD and modified in Fix panic when binding already exists. Version Fix panic when binding already exists of pkg/controller/operators/catalog/step_ensurer.go left in tree.
Patch failed at 0001 Fix panic when binding already exists

In response to this:

/cherry-pick release-4.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants