Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1723851: fix(catalog): do not add owner references to clusterroles or crbs (4.1 cherrypick) #915

Merged
merged 1 commit into from
Jun 27, 2019
Merged

Bug 1723851: fix(catalog): do not add owner references to clusterroles or crbs (4.1 cherrypick) #915

merged 1 commit into from
Jun 27, 2019

Conversation

ecordell
Copy link
Member

Manually cherry-picking, see: #900 (comment)

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 19, 2019
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 19, 2019
@ecordell ecordell changed the title fix(catalog): do not add owner references to clusterroles or crbs Bug 1691546: fix(catalog): do not add owner references to clusterroles or crbs (4.1 cherrypick) Jun 19, 2019
@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jun 19, 2019
@openshift-ci-robot
Copy link
Collaborator

@ecordell: This pull request references an invalid Bugzilla bug:

  • expected the bug to target the "4.1.z" release, but it targets "4.1.0" instead

In response to this:

Bug 1691546: fix(catalog): do not add owner references to clusterroles or crbs (4.1 cherrypick)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ecordell ecordell changed the title Bug 1691546: fix(catalog): do not add owner references to clusterroles or crbs (4.1 cherrypick) fix(catalog): do not add owner references to clusterroles or crbs (4.1 cherrypick) Jun 19, 2019
@openshift-ci-robot openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jun 19, 2019
@openshift-ci-robot
Copy link
Collaborator

@ecordell: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

fix(catalog): do not add owner references to clusterroles or crbs (4.1 cherrypick)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ecordell ecordell changed the title fix(catalog): do not add owner references to clusterroles or crbs (4.1 cherrypick) Bug 1691546: fix(catalog): do not add owner references to clusterroles or crbs (4.1 cherrypick) Jun 19, 2019
@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jun 19, 2019
@openshift-ci-robot
Copy link
Collaborator

@ecordell: This pull request references a valid Bugzilla bug.

In response to this:

Bug 1691546: fix(catalog): do not add owner references to clusterroles or crbs (4.1 cherrypick)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ecordell
Copy link
Member Author

/retest

jpeeler
jpeeler reviewed Jun 24, 2019
View reviewed changes
pkg/controller/operators/catalog/operator.go
// Attempt to create the ClusterRoleBinding.
_, err = o.OpClient.KubernetesInterface().RbacV1().ClusterRoleBindings().Create(&rb)
if k8serrors.IsAlreadyExists(err) {
rb.SetNamespace(plan.Namespace)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

master has the comment duplicated:
// if we're updating, point owner to the newest csv

@jpeeler
Copy link
Contributor

jpeeler commented Jun 24, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 24, 2019
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ecordell, jpeeler

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ecordell ecordell changed the title Bug 1691546: fix(catalog): do not add owner references to clusterroles or crbs (4.1 cherrypick) Bug 1723851: fix(catalog): do not add owner references to clusterroles or crbs (4.1 cherrypick) Jun 25, 2019
@openshift-ci-robot openshift-ci-robot added bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. and removed bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jun 25, 2019
@openshift-ci-robot
Copy link
Collaborator

@ecordell: This pull request references an invalid Bugzilla bug:

  • expected the bug to target the "4.1.z" release, but it targets "---" instead

In response to this:

Bug 1723851: fix(catalog): do not add owner references to clusterroles or crbs (4.1 cherrypick)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ecordell
Copy link
Member Author

/refresh

@ecordell ecordell changed the title Bug 1723851: fix(catalog): do not add owner references to clusterroles or crbs (4.1 cherrypick) fix(catalog): do not add owner references to clusterroles or crbs (4.1 cherrypick) Jun 25, 2019
@openshift-ci-robot
Copy link
Collaborator

@ecordell: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

fix(catalog): do not add owner references to clusterroles or crbs (4.1 cherrypick)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jun 25, 2019
@ecordell ecordell changed the title fix(catalog): do not add owner references to clusterroles or crbs (4.1 cherrypick) Bug 1723851: fix(catalog): do not add owner references to clusterroles or crbs (4.1 cherrypick) Jun 25, 2019
@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jun 25, 2019
@openshift-ci-robot
Copy link
Collaborator

@ecordell: This pull request references a valid Bugzilla bug.

In response to this:

Bug 1723851: fix(catalog): do not add owner references to clusterroles or crbs (4.1 cherrypick)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eparis eparis added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jun 25, 2019
@ecordell
Copy link
Member Author

/retest

@ecordell
Copy link
Member Author

/test unit

2 similar comments
@ecordell
Copy link
Member Author

/test unit

@ecordell
Copy link
Member Author

/test unit

@openshift-merge-robot openshift-merge-robot merged commit b45dae3 into operator-framework:release-4.1 Jun 27, 2019
ecordell pushed a commit to ecordell/operator-lifecycle-manager that referenced this pull request Jul 24, 2019
@openshift-merge-robot
Merge pull request operator-framework#915 from ecordell/fix-crb-4.1
408e4b4 
Bug 1723851: fix(catalog): do not add owner references to clusterroles or crbs (4.1 cherrypick)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpeeler jpeeler jpeeler left review comments

@njhale njhale Awaiting requested review from njhale

Assignees

@jpeeler jpeeler

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ecordell @openshift-ci-robot @jpeeler @eparis @openshift-merge-robot