Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Measure Metadata length by grapheme #2023

Merged
merged 1 commit into from
May 7, 2024
Merged

Measure Metadata length by grapheme #2023

merged 1 commit into from
May 7, 2024

Conversation

kelson42
Copy link
Collaborator

@kelson42 kelson42 commented May 4, 2024

Fixes #2022

@kelson42 kelson42 changed the title Count characters by grapheme Measure Metadata length by grapheme May 4, 2024
src/util/metaData.ts Outdated Show resolved Hide resolved
src/util/metaData.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

@veloman-yunkan veloman-yunkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But please squash all changes into one commit before merging.

@kelson42
Copy link
Collaborator Author

kelson42 commented May 7, 2024

@veloman-yunkan Thx for the review, waiting feedback from the requester because I have changed the values of the accesskeys.

@veloman-yunkan
Copy link
Collaborator

@veloman-yunkan Thx for the review, waiting feedback from the requester because I have changed the values of the accesskeys.

@kelson42 I think that you confuse this PR with kiwix/libkiwix#1075

@kelson42 kelson42 merged commit 9cc613f into main May 7, 2024
3 of 4 checks passed
@kelson42 kelson42 deleted the count-graphemes branch May 7, 2024 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wikipedia_hi_medicine has improper title
2 participants